Closed
Bug 1063015
Opened 10 years ago
Closed 9 years ago
[Browser Start Page] Change History Sub header to Date (today, yesterday, etc)
Categories
(Firefox OS Graveyard :: Gaia::Browser, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: kgrandon)
References
Details
(Keywords: polish, Whiteboard: [systemsfe])
Attachments
(1 file)
Can we update the 'History' sub header to use the day, date, etc that the browser was last used? For example, if it was today, the sub header would be "Today", but this will change on when the browser was last accessed. Updated the visual spec here: https://mozilla.box.com/s/ac65vfmuq1ywl9s2wkqc Thanks!
|
Assignee | |
Comment 1•10 years ago
|
||
We should already support this, see: https://github.com/mozilla-b2g/gaia/blob/master/apps/search/js/providers/places.js#L163 We should have "Today, Yesterday, This Week, This Month, etc.." Can you clarify about what you want to change here?
Flags: needinfo?(epang)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Oh, do you want to simply remove the history header and instead use the first date header?
|
|
Assignee | |
Comment 3•10 years ago
|
||
Yup, seems like that's what we want to do to avoid the duplicate header. Clarified over IRC so removing the flag for now. Thanks!
Blocks: rocketbar-next
Flags: needinfo?(epang)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Polish bug, I choose you!
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
|
||
Comment 5•9 years ago
|
||
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8589199 [details] [review] [gaia] KevinGrandon:bug_1063015_newtab_history_heading > mozilla-b2g:master Dale - could you take a look at this when you get a chance? Thanks!
Attachment #8589199 -
Flags: review?(dale)
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8589199 [details] [review] [gaia] KevinGrandon:bug_1063015_newtab_history_heading > mozilla-b2g:master Nice, this looks good thanks
Attachment #8589199 -
Flags: review?(dale) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 8•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d1912572308c10b11f397f3c3fd878b971ec0b56
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•