1063020 - Tab switching using Ctrl+Tab is broken again in e10s

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(no longer active)]

TypeError: aBrowser.docShell is null browser.js:7852

  // FIXME: This should be part of the PageThumbs API. (bug 1062414)
  _shouldCapture: function Thumbnails_shouldCapture(aBrowser) {
    // Capture only if it's the currently selected tab.
    if (aBrowser != gBrowser.selectedBrowser)
      return false;

    // Don't capture in per-window private browsing mode.
    if (PrivateBrowsingUtils.isWindowPrivate(window))
      return false;

    let doc = aBrowser.contentDocument;

    // FIXME Bug 720575 - Don't capture thumbnails for SVG or XML documents as
    //       that currently regresses Talos SVG tests.
    if (doc instanceof SVGDocument || doc instanceof XMLDocument)
      return false;

    // There's no point in taking screenshot of loading pages.
    if (aBrowser.docShell.busyFlags != Ci.nsIDocShell.BUSY_FLAGS_NONE)
      return false;

The last if statement is where this error happens.

Comment 1

[(no longer active)]

Attachment: Do not attempt to capture screenshots in e10s yet; r=dao

Comment 2

[(no longer active)]

Attachment: Do not attempt to capture screenshots in e10s yet; r=dao

Comment 3

[(no longer active)]

Comment on attachment 8484574 [details] [diff] [review]
Do not attempt to capture screenshots in e10s yet; r=dao

oops!

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/fx-team/rev/9242afae6c77

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9242afae6c77