1063026 - [Utility Tray] Refinements to Music player on utility tray and lockscreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Pang [:epang] UX]

Hi Guillaume,

There are a few issues with the music player on the tray and the lockscreen.

- Layout and alignment seems off for title and artist
- Artist and title should be italic
- The music icons looks a little to large
- Update hit states, we talked about this the other day, but can we follow what is done in headers?  Where on press the icon goes semi transparent and stays that way for a fraction of a second when the user releases?  

Here's a link to the spec:
https://mozilla.box.com/s/2rjzhlh3vym17b85myxr

Let me know if you have any questions and please flag me on ui-reivew when ready for testing :)

Thanks!

Comment 1

[Guillaume Marty [:gmarty]]

Attachment: Github PR

Eric, can you ui-review this patch? I'll then ask for a code review when we're sure it's all right. Thanks!

Comment 2

[Eric Pang [:epang] UX]

added Amy Lee to do a ui-review of the music player on the lockscreen.

Hey Amy, Guillaume made the updates to the Music player on the tray/lockscreen.

I noticed that the highlight states so far only appear in the tray (the icons turns blue then stays blue for 300ms).  Did you want the same thing to happen on lock screen?  Currently it doesn't seem to have a highlight state.  If, so please let Guillaume know, thanks!

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8485007 [details] [review]
Github PR

The music player in the utility tray looks good to me.  I've added Amy to review the music player in the lockscreen.  Please wait for an R+ from her, thanks!

Comment 4

[Amy Lee [:amylee] UX]

(In reply to Eric Pang [:epang] from comment #2)
> added Amy Lee to do a ui-review of the music player on the lockscreen.
> 
> Hey Amy, Guillaume made the updates to the Music player on the
> tray/lockscreen.
> 
> I noticed that the highlight states so far only appear in the tray (the
> icons turns blue then stays blue for 300ms).  Did you want the same thing to
> happen on lock screen?  Currently it doesn't seem to have a highlight state.
> If, so please let Guillaume know, thanks!

Yes I think the highlight states should be consistent across both music players.

Comment 5

[Amy Lee [:amylee] UX]

Comment on attachment 8485007 [details] [review]
Github PR

Guillaume, can you please add the highlight states to the music player on lockscreen so it matches music player in the utility tray? Thanks

Comment 6

[Eric Pang [:epang] UX]

flagging Guillaume on this in case it slips through the cracks.

Comment 7

[Guillaume Marty [:gmarty]]

Comment on attachment 8485007 [details] [review]
Github PR

I fixed the blue highlight to be shown on the lock screen too in the latest version of the patch.
Amy, can you confirm that it looks good to you? Thanks!

Comment 8

[Amy Lee [:amylee] UX]

Comment on attachment 8485007 [details] [review]
Github PR

Hi Guillaume,

This looks good. Thanks!

Comment 9

[Guillaume Marty [:gmarty]]

Comment on attachment 8485007 [details] [review]
Github PR

Thanks Amy for the ui-review.
Tim can you have a look at the patch? It's only a CSS change but it impacts both the utility tray and the lock screen.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8485007 [details] [review]
Github PR

r+ assuming Amy have also give positive feedback on lock screen UI changes.

Comment 11

[Guillaume Marty [:gmarty]]

Thanks Tim.
Merged in https://github.com/mozilla-b2g/gaia/commit/470792e1581897b59b259a0a3fdaeb4112c1c477

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

I'll manually sync this to my on going patch to make LockScreen as an iframe. Thanks Tim's reminder.

Comment 13

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8485007 [details] [review]
Github PR

Manually sync is done.

Comment 14

[Guillaume Marty [:gmarty]]

Comment on attachment 8485007 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Utility tray visual refresh and media player on lockscreen
[User impact] if declined: Less good UI
[Testing completed]: Manual testing needed. Media player appearance should be consistent in both the utility tray and lockscreen
[Risk to taking this patch] (and alternatives if risky): CSS change only, so minor risk
[String changes made]: None

Comment 15

[[:fabrice] Fabrice Desré]

Comment on attachment 8485007 [details] [review]
Github PR

Not bad enough.