Closed Bug 1063028 Opened 10 years ago Closed 10 years ago

Change tests/browser/junit3 Java package root to be org.mozilla.gecko

Categories

(Firefox for Android Graveyard :: Testing, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: nalexander, Assigned: nalexander)

Details

Attachments

(1 file)

At the moment, the Java package root is org.mozilla.gecko.browser.tests.  It generally doesn't make a difference, *except* that if the test package root matches the Fennec package root, then the test package can access package-private classes and functions, including protected static functions.  That's nice!  It makes testing easier.

I just ran across this while trying to write a JUnit 3 test for HomeConfigPrefsBackend.

We should make the browser JUnit 3 test root org.mozilla.gecko, to match Fennec's.
I thought I attached this two days ago, d'oh!  Rubber stamp,
basically, since these tests still don't run on TBPL.
Attachment #8485470 - Flags: review?(rnewman)
This looks fine to me, with the obvious question about why there's suddenly a new test file...?!
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8485470 - Flags: review?(rnewman) → review+
Comment on attachment 8485470 [details] [diff] [review]
Change tests/browser/junit3 Java package root to be org.mozilla.gecko. r=rnewman

Review of attachment 8485470 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/tests/browser/junit3/src/TestRemoteTabsExpandableListAdapter.java
@@ +1,4 @@
> +/* Any copyright is dedicated to the Public Domain.
> +   http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +package org.mozilla.gecko;

Sorry, didn't mean to slip this in to this patch.
https://hg.mozilla.org/mozilla-central/rev/db34423d9a46
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.