1063028 - Change tests/browser/junit3 Java package root to be org.mozilla.gecko

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Nick Alexander :nalexander [he/him]]

At the moment, the Java package root is org.mozilla.gecko.browser.tests.  It generally doesn't make a difference, *except* that if the test package root matches the Fennec package root, then the test package can access package-private classes and functions, including protected static functions.  That's nice!  It makes testing easier.

I just ran across this while trying to write a JUnit 3 test for HomeConfigPrefsBackend.

We should make the browser JUnit 3 test root org.mozilla.gecko, to match Fennec's.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Change tests/browser/junit3 Java package root to be org.mozilla.gecko. r=rnewman

I thought I attached this two days ago, d'oh!  Rubber stamp,
basically, since these tests still don't run on TBPL.

Comment 2

[Richard Newman [:rnewman]]

This looks fine to me, with the obvious question about why there's suddenly a new test file...?!

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8485470 [details] [diff] [review]
Change tests/browser/junit3 Java package root to be org.mozilla.gecko. r=rnewman

Review of attachment 8485470 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/tests/browser/junit3/src/TestRemoteTabsExpandableListAdapter.java
@@ +1,4 @@
> +/* Any copyright is dedicated to the Public Domain.
> +   http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +package org.mozilla.gecko;

Sorry, didn't mean to slip this in to this patch.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/db34423d9a46

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db34423d9a46