Closed
Bug 1063084
Opened 10 years ago
Closed 10 years ago
bmpDecoder incorrectly reports rle4-delta-320x240.bmp as opaque
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
|
2.01 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
We don't support alpha_mask in the bmp decoder but with compression it's possible to use delta to avoid encoding a pixel making it transparent. This is what rle4-delta-320x240.bmp does for the middle region.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
This patch fixes the reftest failure in bug 1056944.
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=aff27d218f5a
|
||
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8484449 [details] [diff] [review] patch Review of attachment 8484449 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense. Thanks for fixing this! (Commit message needs 'r=seth'.)
Attachment #8484449 -
Flags: review?(seth) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/de8ffebb348e
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/de8ffebb348e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•