[marionette-apps] Memoize homescreenURL for app launch

RESOLVED FIXED

Status

Testing Graveyard
JSMarionette
RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: mikehenrty, Assigned: mikehenrty)

Tracking

Details

(Whiteboard: [systemsfe])

Attachments

(3 attachments)

Right now, for every app launch we query the homescreen URL from settings [1]. There have been some intermittent timeouts from this when launching multiple times so let's memoize it.

1.) https://github.com/mozilla-b2g/marionette-apps/blob/b242a28ffcd03778141a26b05e20dee406648f84/lib/launch.js#L9
Created attachment 8484598 [details] [review]
[Pull Request] Memoize homescreenURL
Attachment #8484598 - Flags: review?(jlal)
Whiteboard: [systemsfe]
Comment on attachment 8484598 [details] [review]
[Pull Request] Memoize homescreenURL

landed: https://github.com/mozilla-b2g/marionette-apps/commit/c8ffb75a21bad91dc65ca112df4a104c8a153059

published.
Attachment #8484598 - Flags: review?(jlal) → review+
Created attachment 8485258 [details] [review]
[gaia-node-modules PR] memoize homescreen url
Attachment #8485258 - Flags: review?(jlal)
Attachment #8485258 - Flags: review?(kgrandon)
Comment on attachment 8485258 [details] [review]
[gaia-node-modules PR] memoize homescreen url

Seems fine. You can put r=me for the gaia bump as well. Thanks!
Attachment #8485258 - Flags: review?(kgrandon)
Attachment #8485258 - Flags: review?(jlal)
Attachment #8485258 - Flags: review+
Created attachment 8485268 [details] [review]
[gaia PR] memoize homescreen url in marionette apps

R+ from kgrandon
Attachment #8485268 - Flags: review+
gaia[master]: https://github.com/mozilla-b2g/gaia/commit/174b38c26f5b79b2e9230ae853672a78937e9457
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

3 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.