1063097 - Size of <iframe> inside <panel> gets messed up after changing toolbarbutton image

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Manvel Saroyan]

Attachment: Iframe inside Panel test reproduction in Linux

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.94 Safari/537.36

Steps to reproduce:

1. Install the test add-on from attachment, a window will open.
2. Click on ABP icon, note the red border around the entire panel content (<iframe>).
3. Click on "Press Me" button


Actual results:

Toolbarbutton image changed, but the red border is on the left side of the panel content, the width of the <iframe> is zero for some reason.


Expected results:

Toolbarbutton image changed and iframe keeps the size.

Comment 1

[Manvel Saroyan]

This issue looks to be related to similar one in OSX:
https://bugzilla.mozilla.org/show_bug.cgi?id=1062974

Soon will open another similar bug for Windows.

Comment 2

[Manvel Saroyan]

Attachment: add-on for reproduction in both windows and linux

Steps to reproduce:

1. Install the test add-on from attachment, a window will open.
2. Click on ABP icon, note the red border around the entire panel content (<iframe>).
3. Click on "Press Me" button


Actual results:

Toolbarbutton image changed, but the red border is on the left side of the panel content, the width of the <iframe> is zero for some reason.


Expected results:

Toolbarbutton image changed and iframe keeps the size.

Additional notes:
This is an updated test add-on which also affects windows, tested in Windows (FF v.32.0 and v.35.0a1) and Linux with Firefox stable (v:32.0) and nighly (v:35.0a1).

Comment 3

[Loic]

I tested with the old version Firefox 17, same bug on Win 7.

Comment 4

[Manvel Saroyan]

Attachment: Panel issue reproduction without panel type="arrow"

The issue is appears not to be connected with panel of type="arrow", because it's reproducible even for panels with no type attribute specified, It's again reproducible when panel's content has parent XUL box element.
So the issue is somehow connected with toolbarbutton that has current values of type attribute: panel, menu and menu-button.

Steps to reproduce:

1. Install the test add-on from attachment, a window will open.
2. Click on ABP icon, note the red border around the entire panel content (<iframe>).
3. Click on "Press Me" button


Actual results:

Toolbarbutton image changed, but the red border is on the left side of the panel content, the width of the <iframe> is zero for some reason.


Expected results:

Toolbarbutton image changed and iframe keeps the size.

Comment 5

[Manvel Saroyan]

Looked through bindings for mentioned types of toolbarbutton, but yet no idea what causes the issue:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#132

Comment 6

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID 	20160105030211

I tried to reproduce this on Nightly 46, but I could'n install the add-on from your attachment. Firefox blocks it because "it has not been verified". 

Could you still reproduce the issue? If issue is still reproducing, could you provide an alternative way to reproduce it, considering this add-on can no longer be installed?

Comment 7

[Wladimir Palant]

You have to go to about:config and change xpinstall.signatures.required preference to false, then you will be able to install the add-on. Don't forget to change the pref back once you are finished testing.

Comment 8

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID 	20160106030225

Thanks for advice. I installed the add-on and I reproduced the issue on Firefox 43 and Nightly 46.