1063216 - Fix plural form in Usage widget

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Théo Chevalier]

In bug 1038723, with :gmarty we quickly coded plural forms for Usage widget right before FL, basic testing showed it was working, but since then I did some additional testing and turns out they are not entirely.

The value passed is a string while we need a float, so the case [other] is always picked up :/

Also, by looking at the code, we need a [zero] case for data-available2 when [0.00 <= value <= 0.99], so I'm adding it.
However it's okay for over-limit.

Comment 1

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23746

Tested on Flame 2.2 with different values, to check that the right string was displayed.

Marina, can you take a look please?

Comment 2

[Théo Chevalier]

Updated the PR, Marina made me notice the over limit string was not displayed, because the entity name was wrong (data-over-limit vs. over-limit).
I also removed data-l10n-id="data-limit" from the template, because it contains a variable, and when you open the Utility Tray it briefly shows "Data limit ({{value}})". Now the string is added only at the time we get the value.
I removed data-l10n-id="data-available" for the same reason, and because it was anyway replaced with data-available2 or over-limit string.

This time, tested on device *both* strings.

Comment 3

[Marina Rodríguez [:mai]]

Comment on attachment 8484613 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23746

Works fine, thanks for the effort! r+

Please land once TBPL is green

Comment 4

[Théo Chevalier]

Comment on attachment 8484613 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23746

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1038723
[User impact] if declined: Over limit string won't be displayed, over-limit and data-available strings can't be localized properly (broken plurals).
[Testing completed]: Tested on device with 2.2, both strings with different Data limit and Usage values.
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: added one string to costcontrol.properties for plural

Comment 5

[bhavana bajaj [:bajaj]]

(In reply to Théo Chevalier [:tchevalier] from comment #4)
> Comment on attachment 8484613 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23746
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): Bug 1038723
> [User impact] if declined: Over limit string won't be displayed, over-limit
> and data-available strings can't be localized properly (broken plurals).
> [Testing completed]: Tested on device with 2.2, both strings with different
> Data limit and Usage values.
> [Risk to taking this patch] (and alternatives if risky): very low
> [String changes made]: added one string to costcontrol.properties for plural

waiting for master landing here, please seek approval only after the bug is Fixed on 2.2/master

Comment 6

[Théo Chevalier]

Sorry Bhavana, let's land on master :)
(TBPL errors looks unrelated)

Comment 7

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/e82405469f85db8d181854c1aadc95afa507496c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/e3260b43a61482890b927f9e6d34154ca7bc4401

Comment 9

[Adam Alldredge [:AdamA][Inactive]]

This appears to be a back end issue so we are unable to verify it.