Closed
Bug 1063296
Opened 10 years ago
Closed 10 years ago
Remove debug-mode setters/getters
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1056411
People
(Reporter: evilpies, Assigned: evilpies)
References
Details
Attachments
(3 files)
|
8.62 KB,
patch
|
Details | Diff | Splinter Review | |
|
11.52 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.90 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
The only user of JS_SetRuntimeDebugMode is the shell. The function basically means that every new compartment from that runtime starts out in debug-mode. In stead of putting that flag on the runtime we do the bookkeeping in the shell and introduce a new CompartmentOptions flag.
Attachment #8484699 -
Flags: review?(jorendorff)
Remove all the debug mode setting APIs. We also have the shell function setDebug, which already usually does nothing, because the test were already executed in debug mode. There was one test, that was testing for "setDebugMode". Changing this to using "// |jit-test| debug" makes the test not pass, I am not sure if this ever worked.
Attachment #8484703 -
Flags: review?(jorendorff)
Attachment #8484699 -
Flags: review?(jorendorff)
Attachment #8484703 -
Flags: review?(jorendorff)
Attachment #8484704 -
Flags: review?(jorendorff)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•