1063364 - imgLoader::SetHasProxies/SetHasNoProxies should operate on imgRequests/imgCacheEntrys not URIs

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Timothy Nikkel (:tnikkel)]

There can be more than one imgRequest alive for any given URI, so when we tell the imgLoader that we have/do not have proxies we should be specific which imgRequest/imgCacheEntry this applies to so we don't change the wrong imgRequest/imgCacheEntry.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

I don't know if this causes any problems in practice, but we shouldn't leave dangerous things lying around.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8484792 [details] [diff] [review]
patch

Review of attachment 8484792 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks for fixing this!

::: image/src/imgLoader.h
@@ +323,5 @@
>    // HasObservers(). The request's cache entry will be re-set before this
>    // happens, by calling imgRequest::SetCacheEntry() when an entry with no
>    // observers is re-requested.
> +  bool SetHasNoProxies(imgRequest *request, imgCacheEntry *entry);
> +  bool SetHasProxies(imgRequest *request);

Nit: As long as we're changing these, it'd be nice to update them to use the current Mozilla coding style. |imgRequest* aRequest| and so forth.

I'm trying to gradually update things as they get touched.

Comment 3

[Timothy Nikkel (:tnikkel)]

fixed that, landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/df7e3ce580ea

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df7e3ce580ea