Investigate why cookie exception test (browser_cookies_exceptions.js) has observer callbacks where we weren't expecting any

NEW
Unassigned

Status

()

Firefox
Preferences
4 years ago
3 years ago

People

(Reporter: Gijs, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
2
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
See: bug 1062631 comment 7:

http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/tests/browser_cookies_exceptions.js?rev=ca8d8f284b99#135

> This test says this case shouldn't happen, but it does. If this test included
> an ok(false) at this point, it would be failing on tinderbox. This patch
> preserves
> the existing behavior of bailing out, and just does it explicitly rather
> than with
> an unreported exception.


Blair, seems you reviewed this... any ideas? I'm worried that this might point to an actual code problem, as I didn't see the test issue when looking casually. Because of this, backlog+'ing this.

(should be fairly easy to just set a conditional breakpoint in the browser debugger and see in what circumstance this is getting hit)
Flags: qe-verify-
Flags: needinfo?(bmcbride)
Flags: in-testsuite+
Flags: firefox-backlog+
Ugh, seems I missed the need for a ok(false) there.

No insights, sorry - I'd need to see what notification were getting there (if it weren't after midnight, I'd look now myself).
Flags: needinfo?(bmcbride)
You need to log in before you can comment on or make changes to this bug.