1063414 - Make DIRS relative to the file they were added from, instead of from the main moz.build in case of includes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I think it's not entirely obvious, when one looks at included mozbuild files that the DIRS that are in them are relative to wherever the mozbuild was included from, as opposed to relative to the included mozbuild. More generally, this should be true for other variables than DIRS, but baby steps. With bug 1062221, DIRS is the only variable that has automatic handling of this.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move sandbox execution stack to context.Context

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add infrastructure to follow what the current file being processed is in a Context

Previous title was wrong.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Move sandbox execution stack to context.Context

Comment 4

[Mike Hommey [:glandium]]

Attachment: Make DIRS relative to the file they were added from

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8484857 [details] [diff] [review]
Add infrastructure to follow what the current file being processed is in a Context

Review of attachment 8484857 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/test/frontend/test_context.py
@@ +100,5 @@
> +        test = Context()
> +
> +        # Newly created context has no paths.
> +        self.assertEqual(test.main_path, None)
> +        self.assertEqual(test.current_path, None)

I believe there is an self.assertIsNone()

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8484860 [details] [diff] [review]
Make DIRS relative to the file they were added from

Review of attachment 8484860 [details] [diff] [review]:
-----------------------------------------------------------------

I love how app.mozbuild and toolkit.mozbuild are much clearer now. The inclusion of these files and the weird semantics that brought with always bothered me.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ac3369095af
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ed602393f8d
https://hg.mozilla.org/integration/mozilla-inbound/rev/6986ab0f163e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4ac3369095af
https://hg.mozilla.org/mozilla-central/rev/8ed602393f8d
https://hg.mozilla.org/mozilla-central/rev/6986ab0f163e