1063518 - "Learn More" link for the Mozilla Location Service is visible on Beta/Release despite MLS setting not available

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[K Lars Lohn [:lars] [:klohn]]

Attachment: screenshot of link under heading "Crash Reporter"

In the Settings -> Mozilla section of FF Android Beta, there is a select box with the heading "Crash Reporter".  Immediately below that is a "Learn More" link.  Pressing that link take the user to a page about "Mozilla Location Service".

Either the "Learn More" link is missing a "Location Service" label or the link is erroneously going to "Location Service" instead of "Crash Reporter"  

ASUS Model K010; Android 4.4.2

Comment 1

[Aaron Train [:aaronmt]]

Oh, that learn more link is for the 'Mozilla Location Service', which is an opt-in setting that appears under the 'Crash Reporter' setting. It is currently disabled on beta & release. We shouldn't be showing that link if the service is not enabled.

Comment 2

[:Margaret Leibovic]

Attachment: Hide MLS "Learn More" link when MLS is disabled

I just modeled this after what we already do for the health report learn more link. Oddly enough, there was already a PREFS_GEO_LEARN_MORE constant, but it was unused.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/5071f4bd6109

Comment 4

[:Margaret Leibovic]

Comment on attachment 8485678 [details] [diff] [review]
Hide MLS "Learn More" link when MLS is disabled

Approval Request Comment
[Feature/regressing bug #]: regression from bug 903535
[User impact if declined]: unrelated "Learn more" link appears under crash reporter preference
[Describe test coverage new/current, TBPL]: no tests
[Risks and why]: low-risk, adds check to hide MLS "Learn more" link when MLS preference is hidden
[String/UUID change made/needed]: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5071f4bd6109

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8485678 [details] [diff] [review]
Hide MLS "Learn More" link when MLS is disabled

Looks simple enough and it's good to clean this up. Beta+ and Aurora+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cc4c10c8580d
https://hg.mozilla.org/releases/mozilla-beta/rev/275330447f6d

Comment 8

[u421692]

Verified as fixed on Firefox 33 Beta 4 on Samsung Galaxy Nexus (Android 4.2.1)

Comment 9

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed on
Build: Firefox for Android 34 Beta 1
Device: Asus Transformer Pad TF300T (Android 4.2.1)

Comment 10

[Cristina Madaras, QA [:CristinaM]]

On Firefox for Android 35 Beta 1 build 2, 'Mozilla Location Service' setting is displayed under the 'Crash Reporter' setting. Isn't this service disabled on Beta and release?

Comment 11

[Cristina Madaras, QA [:CristinaM]]

(In reply to Cristina Madaras, QA [:CristinaM] from comment #10)
> On Firefox for Android 35 Beta 1 build 2, 'Mozilla Location Service' setting
> is displayed under the 'Crash Reporter' setting. Isn't this service disabled
> on Beta and release?

Since MLS is available again, 'Mozilla Location Service' setting and 'Learn more' link are correctly displayed. I will mark this as Verified fixed.

Comment 12

[:Margaret Leibovic]

(In reply to Cristina Madaras, QA [:CristinaM] from comment #10)
> On Firefox for Android 35 Beta 1 build 2, 'Mozilla Location Service' setting
> is displayed under the 'Crash Reporter' setting. Isn't this service disabled
> on Beta and release?

No, it's shipping in Firefox 35 beta: https://www-dev.allizom.org/en-US/mobile/35.0beta/releasenotes/