Closed Bug 1063584 Opened 6 years ago Closed 5 years ago

Update tests have to modify the 'update-settings.ini' file because the new signed builds on OS X

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1, major)

Tracking

(firefox32 fixed, firefox33 fixed, firefox34 fixed, firefox35 fixed, firefox-esr31 fixed)

RESOLVED FIXED
Tracking Status
firefox32 --- fixed
firefox33 --- fixed
firefox34 --- fixed
firefox35 --- fixed
firefox-esr31 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [status-mozilla-esr24: fixed])

Attachments

(4 files)

+++ This bug was initially created as a clone of Bug #1060599 +++

Similar to bug 1060599 our tests now have to set the correct entries in the given ini file. To be able to do that we first need a new release of mozmill-automation, which sets the necessary properties on the persisted object.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Something I noticed while working on this bug, the RawConfigParser in Python somewhat writes entries like: "key = value", which means we have extra spaces for the key and the value. A temporary workaround is to add trim() calls for now. We may be able to change something in the automation scripts, but that would mean an extra release we would have to do.
This adds the changes for the mar channel handling, and also includes some other additions. This is part 1. Part 2 will follow once the next automation release happened.
Attachment #8493122 - Flags: review?(andreea.matei)
Comment on attachment 8493122 [details] [diff] [review]
MAR channel handling v1

Review of attachment 8493122 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8493122 - Flags: review?(andreea.matei) → review+
Thanks Andreea. I pushed this to default:

https://hg.mozilla.org/qa/mozmill-tests/rev/eb0e7205e2d8

If all is fine I will backport it step by step to older branches. There is no way to set the wanted flag for esr24, but that's what we need here too.
Whiteboard: [also needs landing on mozilla-esr24]
Given that the targetBuildID is optional I totally missed to update this property to the new location.
Attachment #8493644 - Flags: review?(andreea.matei)
Comment on attachment 8493644 [details] [diff] [review]
Fix targetBuildID v1

Review of attachment 8493644 [details] [diff] [review]:
-----------------------------------------------------------------

All good.
Attachment #8493644 - Flags: review?(andreea.matei) → review+
Landed the targetBuildID patch as:

https://hg.mozilla.org/qa/mozmill-tests/rev/1718b3b68b10 (default)
Attachment #8493122 - Flags: checkin+
Attachment #8493644 - Flags: checkin+
This patch is just a combined version of the already landed patches.
Attachment #8493720 - Flags: review?(andreea.matei)
Comment on attachment 8493720 [details] [diff] [review]
Combined backport patch v1

Review of attachment 8493720 [details] [diff] [review]:
-----------------------------------------------------------------

All good.
Attachment #8493720 - Flags: review?(andreea.matei) → review+
Comment on attachment 8493720 [details] [diff] [review]
Combined backport patch v1

Landed combined backport patch for aurora:

https://hg.mozilla.org/qa/mozmill-tests/rev/3e8db12d1a31
Attachment #8493720 - Flags: checkin+
Whiteboard: [also needs landing on mozilla-esr24] → [status-mozilla-esr24: affected]
https://hg.mozilla.org/qa/mozmill-tests/rev/661d8556403e (beta)

I will do a couple of ondemand_update testruns on staging to verify all is working fine before pushing to release, and the esr channels.
Everything looks fine with this patch on beta, except the fact that the --overwrite-update-url option used by ondemand_update tests is causing us problems here. If we really get other releases this week, we can temporarily remove this option to make everything pass.
The backport here is mostly necessary because of the still not finished 'a' prefix bug. :(
Blocks: 883120
Attachment #8495157 - Flags: review?(andreea.matei)
Comment on attachment 8495157 [details] [diff] [review]
Combined backport (release) v1

Review of attachment 8495157 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8495157 - Flags: review?(andreea.matei) → review+
https://hg.mozilla.org/qa/mozmill-tests/rev/676ba9313a34 (release)
https://hg.mozilla.org/qa/mozmill-tests/rev/4143a4c70a96 (esr31)
https://hg.mozilla.org/qa/mozmill-tests/rev/01c0edbf2e82 (esr24)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [status-mozilla-esr24: affected] → [status-mozilla-esr24: fixed]
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.