1063584 - Update tests have to modify the 'update-settings.ini' file because the new signed builds on OS X

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

+++ This bug was initially created as a clone of Bug #1060599 +++

Similar to bug 1060599 our tests now have to set the correct entries in the given ini file. To be able to do that we first need a new release of mozmill-automation, which sets the necessary properties on the persisted object.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Something I noticed while working on this bug, the RawConfigParser in Python somewhat writes entries like: "key = value", which means we have extra spaces for the key and the value. A temporary workaround is to add trim() calls for now. We may be able to change something in the automation scripts, but that would mean an extra release we would have to do.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: MAR channel handling v1

This adds the changes for the mar channel handling, and also includes some other additions. This is part 1. Part 2 will follow once the next automation release happened.

Comment 3

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8493122 [details] [diff] [review]
MAR channel handling v1

Review of attachment 8493122 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Thanks Andreea. I pushed this to default:

https://hg.mozilla.org/qa/mozmill-tests/rev/eb0e7205e2d8

If all is fine I will backport it step by step to older branches. There is no way to set the wanted flag for esr24, but that's what we need here too.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: Fix targetBuildID v1

Given that the targetBuildID is optional I totally missed to update this property to the new location.

Comment 6

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8493644 [details] [diff] [review]
Fix targetBuildID v1

Review of attachment 8493644 [details] [diff] [review]:
-----------------------------------------------------------------

All good.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Landed the targetBuildID patch as:

https://hg.mozilla.org/qa/mozmill-tests/rev/1718b3b68b10 (default)

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: Combined backport patch v1

This patch is just a combined version of the already landed patches.

Comment 9

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8493720 [details] [diff] [review]
Combined backport patch v1

Review of attachment 8493720 [details] [diff] [review]:
-----------------------------------------------------------------

All good.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 8493720 [details] [diff] [review]
Combined backport patch v1

Landed combined backport patch for aurora:

https://hg.mozilla.org/qa/mozmill-tests/rev/3e8db12d1a31

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

https://hg.mozilla.org/qa/mozmill-tests/rev/661d8556403e (beta)

I will do a couple of ondemand_update testruns on staging to verify all is working fine before pushing to release, and the esr channels.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Everything looks fine with this patch on beta, except the fact that the --overwrite-update-url option used by ondemand_update tests is causing us problems here. If we really get other releases this week, we can temporarily remove this option to make everything pass.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

The backport here is mostly necessary because of the still not finished 'a' prefix bug. :(

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: Combined backport (release) v1

Comment 15

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8495157 [details] [diff] [review]
Combined backport (release) v1

Review of attachment 8495157 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

https://hg.mozilla.org/qa/mozmill-tests/rev/676ba9313a34 (release)
https://hg.mozilla.org/qa/mozmill-tests/rev/4143a4c70a96 (esr31)
https://hg.mozilla.org/qa/mozmill-tests/rev/01c0edbf2e82 (esr24)