Closed
Bug 1063688
Opened 11 years ago
Closed 11 years ago
Convert treeherder-service regexes to raw string literals
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
Attachments
(1 file)
(In reply to Ed Morley [:edmorley] from bug 1043741 comment #7)
> * Switches the regex to raw literal string, since it's safer (we should
> probably do this everywhere at some point).
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → emorley
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8550707 -
Flags: review?(cdawson)
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8550707 [details] [review]
Use raw string literals for regexes
lgtm!
Attachment #8550707 -
Flags: review?(cdawson) → review+
|
||
Comment 3•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-service
https://github.com/mozilla/treeherder-service/commit/31acccb58082b3cbcfb8bc44c10d3c2346962701
Bug 1063688 - Use raw string literals for regexes
Since it avoids backslash expressions from being mis-interpreted if they
happen to match an escape sequence (eg '\b', '\n', ...).
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•