1063783 - SettingsService shouldn't be passing a null principal to sendAsyncMessage

Status: RESOLVED INCOMPLETE

(Core :: DOM: Device Interfaces, defect)

Description

[Reuben Morais [:reuben]]

Attachment: Don't pass a null principal to sendAsyncMessage

See bug 1058440 comment 13. It just causes the AssertAppProcess call to fail when SettingsService is called from an app.

Comment 1

[Reuben Morais [:reuben]]

Comment on attachment 8485219 [details] [diff] [review]
Don't pass a null principal to sendAsyncMessage

So as discussed on IRC this is not what we want. I'm trying to think of a better way to handle this.

Comment 2

[Reuben Morais [:reuben]]

Ugh, I'm not sure what to do here, even just accepting the system principal in AssertAppPrincipal is tricky, it's a pointer value that obviously is not consistent across processes…

It seems like SettingsService needs a different protocol to the parent that doesn't try to do principal validation.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Cleaning up Device Interfaces component, and mass-marking old FxOS bugs as incomplete.

If any of these bugs are still valid, please let me know.