1063818 - Updates to form.dev-engagement-event

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Custom Bug Entry Forms, defect)

Description

[John Karahalis [:openjck]]

In June, Robyn Chau and I met with Dave Lawrence to discuss some additions we were hoping could be made to the Developer Events form. We discussed adding new fields, reflecting field values in the status whiteboard, and automatically opening additional bugs when the form was submitted.

We were able to compile a list of requirements, which are available below:

https://docs.google.com/a/mozilla.com/document/d/1jTNreCelyYk2Bi31L18dUzikr3yGeBdTwrWAqnbOR6o/edit#

We so appreciate the interest in helping. These additions will be a huge win for Developer Event team productivity. Please let us know if you have any questions.

Comment 1

[David Lawrence [:dkl]]

Comments/Questions:

1) I will need a bit more information for the new component outlined here:
https://wiki.mozilla.org/BMO/Requesting_Changes#Components
2) I will need a brief description for each of the keywords listed.
3) This is quite a bit of change over the current form as you have mentioned. What is the timeframe you would like to have this completed and live by? Taking into account time needed for testing and feedback.

Thanks
dkl

Comment 2

[John Karahalis [:openjck]]

(In reply to David Lawrence [:dkl] from comment #1)
> Comments/Questions:
> 
> 1) I will need a bit more information for the new component outlined here:
> https://wiki.mozilla.org/BMO/Requesting_Changes#Components

Ah, yes. I updated the document with that information.

> 2) I will need a brief description for each of the keywords listed.

Great! Updated the document with that information.

> 3) This is quite a bit of change over the current form as you have
> mentioned. What is the timeframe you would like to have this completed and
> live by? Taking into account time needed for testing and feedback.

With testing and feedback, how does 1-1.5 months sound?

> Thanks
> dkl

Comment 3

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #2)
> (In reply to David Lawrence [:dkl] from comment #1)
> > Comments/Questions:
> > 
> > 1) I will need a bit more information for the new component outlined here:
> > https://wiki.mozilla.org/BMO/Requesting_Changes#Components
> 
> Ah, yes. I updated the document with that information.
> 
> > 2) I will need a brief description for each of the keywords listed.
> 
> Great! Updated the document with that information.

Thanks for the edits. Will add them to my test environment so I can test the form changes.

> > 3) This is quite a bit of change over the current form as you have
> > mentioned. What is the timeframe you would like to have this completed and
> > live by? Taking into account time needed for testing and feedback.
> 
> With testing and feedback, how does 1-1.5 months sound?

Sounds about right :)

dkl

Comment 4

[John Karahalis [:openjck]]

Hi David,

The Developer Events team would like to do another round of feedback on these updates. I don't expect anything major to be affected -- maybe some keyword names, or an added question or two. I expect that the higher-level bits (saving some values in the whiteboard, opening discussion bugs, conditionally showing questions, etc.) will remain unchanged.

If you'd like to pause on this while the team shares some more feedback, though, that would be fine. I'm sorry for any inconvenience.

Comment 5

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #4)
> Hi David,
> 
> The Developer Events team would like to do another round of feedback on
> these updates. I don't expect anything major to be affected -- maybe some
> keyword names, or an added question or two. I expect that the higher-level
> bits (saving some values in the whiteboard, opening discussion bugs,
> conditionally showing questions, etc.) will remain unchanged.
> 
> If you'd like to pause on this while the team shares some more feedback,
> though, that would be fine. I'm sorry for any inconvenience.

Ok. Setting needinfo? so that reminds me that I waiting to hear back from you before continuing.

dkl

Comment 6

[John Karahalis [:openjck]]

Hi David,

That last feedback cycle just wrapped up. No major changes, but we did decide to remove two questions and rename a small number of fields, options, and whiteboard keys.

All of these changes have been reflected in the document. If it helps, the revision history tool (File > See revision history) can be used to see a diff of the changes. These particular changes were made to the document on September 19th.

We're all set to move forward on this. Thanks David!

Comment 7

[John Karahalis [:openjck]]

Hi David,

Just wanted to stop by and also double-check that comment 6 was seen. Are we on schedule for 1-1.5 months from comment 6 -- late October / early November? Thanks again for everything. We so appreciate your work on this.

Comment 8

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #7)
> Hi David,
> 
> Just wanted to stop by and also double-check that comment 6 was seen. Are we
> on schedule for 1-1.5 months from comment 6 -- late October / early
> November? Thanks again for everything. We so appreciate your work on this.

Got backed up with some other tasks but should be able to start on this tomorrow and finish in the timeframe proposed.

dkl

Comment 9

[John Karahalis [:openjck]]

Great! Thank you so much, David. Please let us know if there's anything we can do to help.

Comment 10

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #9)
> Great! Thank you so much, David. Please let us know if there's anything we
> can do to help.

Ok I have a initial version of the form ready for feedback at:

https://bugzilla-dev.allizom.org/form.dev-engagement-event

Please take it through the flow and see if you encounter any issues or if I missed something
from the requirements.

Thanks
dkl

Comment 11

[Justin Crawford [:hoosteeno] [:jcrawford]]

Nice!

:openjck,do you think we need an example or validation for "Mozillians URL"? In the past we have asked for this (notoriously, at Summit 2013) and gotten all manner of things that were not Mozillians URLs (such as IRC handles, personal blog URLs, Mozillians usernames, bugzilla profiles). <em>e.g. https://mozillians.org/en-US/u/hoosteeno/</em> is what I'm thinking.

I just submitted an event in the past. Not sure this warrants a fix, but you can be the judge of that.

Comment 12

[David Lawrence [:dkl]]

(In reply to Justin Crawford [:hoosteeno] from comment #11)
> Nice!
> 
> :openjck,do you think we need an example or validation for "Mozillians URL"?
> In the past we have asked for this (notoriously, at Summit 2013) and gotten
> all manner of things that were not Mozillians URLs (such as IRC handles,
> personal blog URLs, Mozillians usernames, bugzilla profiles). <em>e.g.
> https://mozillians.org/en-US/u/hoosteeno/</em> is what I'm thinking.
> 
> I just submitted an event in the past. Not sure this warrants a fix, but you
> can be the judge of that.

I can add a sample placeholder in most of the text fields with examples if you provide some.

dkl

Comment 13

[John Karahalis [:openjck]]

This is so great. I can't communicate how happy I am about how this turned out. This conforms exactly to our specification and I can't wait to start using the new features. Thank you so much David.

I noticed just two minor bugs:

* The Event Location Description field is required, but doesn't have a red
  asterisk.
* When the Event Location Description field is left empty, the error message
  says that the Event Location field needs to be filled in. The message should
  say that the Event Location Description field needs to be filled in.

I was also wondering if it would be possible to make the two following additions:

1. Can we add [e-mail] as a NEEDINFO on the discussion bug?

2. We were also wondering if it would be possible to add a section to the end of
   the request bug that formats some of the entered information such that it
   could be easily copied and pasted into a spreadsheet that the team uses. To
   facilitate copy/pasting, the format would need to be like this:

> Event name [tab] Start date [tab] End date [tab] Location [tab] Number of expected attendees [tab] Primary audience [tab] Event description [tab] Names of participating people from Mozilla [tab] What is being requested

   For example...

> JSConf [tab] 2014-01-01 [tab] 2014-01-02 [tab] New York, NY, USA [tab] Somewhere around 5,000 [tab] JavaScript programmers [tab] Lorem ipsum... [tab] Christian, Julie, and Robert [tab] Keynote Presentation, Workshop, Sponsorship

   Would that be possible? That automation would really help the team do their
   work more quickly.

Thanks again so much, David. I can't tell you how excited we are about this. :-)

Comment 14

[John Karahalis [:openjck]]

Just to be extra clear, the formatted information shouldn't start with the ">" character. I just put that there so that the examples would be formatted differently.

Comment 15

[David Lawrence [:dkl]]

Thanks for the feedback.

(In reply to John Karahalis [:openjck] from comment #13)
> This is so great. I can't communicate how happy I am about how this turned
> out. This conforms exactly to our specification and I can't wait to start
> using the new features. Thank you so much David.
> 
> I noticed just two minor bugs:
> 
> * The Event Location Description field is required, but doesn't have a red
>   asterisk.
> * When the Event Location Description field is left empty, the error message
>   says that the Event Location field needs to be filled in. The message
> should
>   say that the Event Location Description field needs to be filled in.

Fixed
 
> I was also wondering if it would be possible to make the two following
> additions:
> 
> 1. Can we add [e-mail] as a NEEDINFO on the discussion bug?

Done

> 2. We were also wondering if it would be possible to add a section to the
> end of
>    the request bug that formats some of the entered information such that it
>    could be easily copied and pasted into a spreadsheet that the team uses.
> To
>    facilitate copy/pasting, the format would need to be like this:
> 
> > Event name [tab] Start date [tab] End date [tab] Location [tab] Number of expected attendees [tab] Primary audience [tab] Event description [tab] Names of participating people from Mozilla [tab] What is being requested
> 
>    For example...
> 
> > JSConf [tab] 2014-01-01 [tab] 2014-01-02 [tab] New York, NY, USA [tab] Somewhere around 5,000 [tab] JavaScript programmers [tab] Lorem ipsum... [tab] Christian, Julie, and Robert [tab] Keynote Presentation, Workshop, Sponsorship
> 
>    Would that be possible? That automation would really help the team do
> their
>    work more quickly.

Should definitely be possible. Let me work on that a bit and will let you know when the next version is up for feedback.

dkl

Comment 16

[John Karahalis [:openjck]]

Wow, you're fast! That sounds great. Thank you David.

The team is testing the form and might have some additional feedback soon. So far it's all been very minor -- mostly non-technical things like question phrasing.

One that Sandra noticed is that in the third question ("What is your role...") the word attendee is incorrectly spelled as "atendee".

Comment 17

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #16)
> One that Sandra noticed is that in the third question ("What is your
> role...") the word attendee is incorrectly spelled as "atendee".

Thanks, fixed.

Comment 18

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #15) 
> > > JSConf [tab] 2014-01-01 [tab] 2014-01-02 [tab] New York, NY, USA [tab] Somewhere around 5,000 [tab] JavaScript programmers [tab] Lorem ipsum... [tab] Christian, Julie, and Robert [tab] Keynote Presentation, Workshop, Sponsorship
> > 
> >    Would that be possible? That automation would really help the team do
> > their
> >    work more quickly.
> 
> Should definitely be possible. Let me work on that a bit and will let you
> know when the next version is up for feedback.

After some experimentation and talking with colleague, the only way we can do this is to create an attachment that you can click on that will have this string in the attachment. It will be a text/plain that has the tabs in it properly. It was not possible to do this in the bug comment itself. Let me know if this is unacceptable. It is just one extra click really.

dkl

Comment 19

[David Lawrence [:dkl]]

Ok I have update the form on our test instance.

1. Small fixes previously mentioned
2. Added needinfo [e-mail] to discussion bug
3. Creates a "Spreadsheet Data" attachment to the request bug with tab delimited values requested

https://bugzilla-dev.allizom.org/form.dev-engagement-event

dkl

Comment 20

[John Karahalis [:openjck]]

Awesome! This looks great, David.

I emailed Sandra (spersing@) to review the spreadsheet data feature. I'll add a comment summarizing her thoughts soon.

Another small change has been requested through team feedback. Can we change the text "The Developer Events Team usually doesn’t sponsor..." to be black instead of red? Some users are interpreting the color to mean that form submission has been disabled because red is used for other form-disabling error messages.

Comment 21

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #20)
> Another small change has been requested through team feedback. Can we change
> the text "The Developer Events Team usually doesn’t sponsor..." to be black
> instead of red? Some users are interpreting the color to mean that form
> submission has been disabled because red is used for other form-disabling
> error messages.

Fixed locally. Will be in the next batch of updates.

Comment 22

[John Karahalis [:openjck]]

Just wanted to share an update. Robyn, one of the main drivers behind the improvements, has been at a conference this week. I'll ask her to review when she gets back and has the chance to catch up.

Comment 23

[John Karahalis [:openjck]]

A few more requests from the feedback cycle:

* I

Comment 24

[John Karahalis [:openjck]]

A few more requests from the feedback cycle:

* In the "Event Location" field, Australia is misspelled
* Please update the "primary audience" help text to [1]
* Please add help text [2] to the "If requesting sponsorship" question

[1] For example: Front-end web developers, back-end web developers, mobile web
    developers, UI/UX designers, business development, marketing associates,
    corporate executives, etc. Please be specific. For developers, please
    include the platforms and programming languages that the developers are
    most likely to be interested in.
[2] Please include the currency.

Comment 25

[John Karahalis [:openjck]]

One more:

Would it be possible to ensure that the [location:...], [requesting:...], and [products:...] tags appear first in the whiteboard?

Comment 26

[John Karahalis [:openjck]]

Another piece of feedback:

* In the "What are you requesting" question, can we rewrite non_keynote as
  non-keynote?

Comment 27

[David Lawrence [:dkl]]

Ok I have updated the form on our test instance with the latest suggested changes.

https://bugzilla-dev.allizom.org/form.dev-engagement-event

dkl

Comment 28

[John Karahalis [:openjck]]

Hi David,

A few more pieces of feedback from the team.

* Please add [e-mail] as a default NEEDINFO
* Please remove [e-mail] as a default NEEDINFO
* Please add "Developer Tools" as an option in the "Relevant Products" question
  and reflect that choice in the associated whiteboard tag and wherever else
  answers to that question appear.
* Please remove the "Who is the primary audience for this event" quesiton. Sorry
  about this. We originally wanted to include this for metrics-gathering
  purposes, but on further inspection the team decided to keep the form as
  simple as possible instead.

We also noticed that when the "Spreadsheet Data" is copied and pasted directly into a Google Spreadsheet the tabs are not converted to column breaks as expected. However, if the Spreadsheet Data is first copied into a text editor, then copied from the text editor into a Google Spreadsheet, the tabs /are/ converted to column breaks.

I don't think this has anything to do with how you implemented it, but I was wondering... do you have any idea as to why that might be happening?

Comment 29

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #28)
> Hi David,
> 
> A few more pieces of feedback from the team.
> 
> * Please add [e-mail] as a default NEEDINFO
> * Please remove [e-mail] as a default NEEDINFO
> * Please add "Developer Tools" as an option in the "Relevant Products"
> question
>   and reflect that choice in the associated whiteboard tag and wherever else
>   answers to that question appear.
> * Please remove the "Who is the primary audience for this event" quesiton.
> Sorry
>   about this. We originally wanted to include this for metrics-gathering
>   purposes, but on further inspection the team decided to keep the form as
>   simple as possible instead.

Ok I have updated the form on our test instance with the above suggested changes.

https://bugzilla-dev.allizom.org/form.dev-engagement-event

> We also noticed that when the "Spreadsheet Data" is copied and pasted
> directly into a Google Spreadsheet the tabs are not converted to column
> breaks as expected. However, if the Spreadsheet Data is first copied into a
> text editor, then copied from the text editor into a Google Spreadsheet, the
> tabs /are/ converted to column breaks.
> 
> I don't think this has anything to do with how you implemented it, but I was
> wondering... do you have any idea as to why that might be happening?

Not sure on this. Will need to investigate and maybe play around with a sample Google Spreadsheet to see if I can reproduce. If you could provide me with some sample data that you create that imports properly, I can try to match my data to it.

Thanks
dkl

Comment 30

[John Karahalis [:openjck]]

Hi David,

The team is super excited about the new form and there doesn't appear to be any more feedback right now. We're ready to launch whenever you are.

I'll continue looking into the copy/paste issue and can open a bug about it later. It may be a peculiarity of the browser -- the paste works correctly if the text is copied from a textarea. Worst case scenario, we can wrap the text in a textarea as a workaround.

We are so appreciative for your work on this. Thanks for making the Developer Events process so much easier for all of us.

Comment 31

[David Lawrence [:dkl]]

(In reply to John Karahalis [:openjck] from comment #30)
> Hi David,
> 
> The team is super excited about the new form and there doesn't appear to be
> any more feedback right now. We're ready to launch whenever you are.
> 
> I'll continue looking into the copy/paste issue and can open a bug about it
> later. It may be a peculiarity of the browser -- the paste works correctly
> if the text is copied from a textarea. Worst case scenario, we can wrap the
> text in a textarea as a workaround.
> 
> We are so appreciative for your work on this. Thanks for making the
> Developer Events process so much easier for all of us.

Great to hear. If you can open a new bug once this is closed outlining the issue with the spreadsheet data, I will work on it separately. Please attach a sample line that works also to the new bug as requested in comment 29.

I will commit this today but due to the work week next week, it will not likely go live til the week after we all return.

dkl

Comment 32

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   55d148d..412b826  master -> master

Comment 33

[John Karahalis [:openjck]]

(In reply to David Lawrence [:dkl] from comment #31)
> I will commit this today but due to the work week next week, it will not
> likely go live til the week after we all return.

Works for me! That's probably for the best, actually.