1063859 - JavaScript Warning: "reference to undefined property this.notifications[origin]" {file: "resource://gre/modules/NotificationDB.jsm" line: 296}]

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gregor Wagner [:gwagner]]

Seen on flame with debug gecko during startup with fresh profile on trunk.

E/GeckoConsole(  224): [JavaScript Warning: "reference to undefined property this.notifications[origin]" {file: "resource://gre/modules/NotificationDB.jsm" line: 296}]

Comment 1

[Gregor Wagner [:gwagner]]

Can we fix this?

Comment 2

[:gerard-majax]

That makes sense: this.notifications is empty, and we are trying to iterate over this.notifications[origin].

Comment 3

[:gerard-majax]

Attachment: Do not iterate on undefined valued when querying notifications r=mhenretty

When we are performing the getAll/getAllCrossOrigin requests and there
is no notifications, then this.notifications[origin] (with a valid
origin) is just undefined. We should make sure we do not iterate over in
this case.

Comment 4

[:gerard-majax]

Attachment: Do not iterate on undefined valued when querying notifications r=mhenretty

When we are performing the getAll/getAllCrossOrigin requests and there
is no notifications, then this.notifications[origin] (with a valid
origin) is just undefined. We should make sure we do not iterate over in
this case.

Comment 5

[:gerard-majax]

Comment on attachment 8493789 [details] [diff] [review]
Do not iterate on undefined valued when querying notifications r=mhenretty

This does fix locally.

Pending try:
https://tbpl.mozilla.org/?tree=Try&rev=4824e4251197
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4824e4251197

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8493789 [details] [diff] [review]
Do not iterate on undefined valued when querying notifications r=mhenretty

Review of attachment 8493789 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cab3537db5c5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cab3537db5c5