Closed Bug 1063868 Opened 6 years ago Closed 6 years ago

Add a build flag to exclude fonts from Android builds

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: rnewman, Assigned: rnewman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This change alone cuts our APK size by 2.75MB.
Attachment #8485337 - Flags: review?(nalexander)
Attachment #8485337 - Flags: review?(mark.finkle)
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment on attachment 8485337 [details] [diff] [review]
Exclude fonts from constrained APKs. v1

I wouldn't mind being more specific with the flag here. We might also use this code for packaging GeckoView too.

Maybe change:
MOZ_ANDROID_RESOURCE_CONSTRAINED

to:
MOZ_ANDROID_BUNDLE_FONTS

And then also set MOZ_ANDROID_BUNDLE_FONTS when building a resource constrained APK.
Attachment #8485337 - Flags: review?(mark.finkle) → feedback+
Comment on attachment 8485337 [details] [diff] [review]
Exclude fonts from constrained APKs. v1

Review of attachment 8485337 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this lagged; I thought I cleared it but it was in a background tab.

I agree with mfinkle: consider a fine-grained fonts guard that is set by the coarser resource constrained guard.  I'm not too concerned either way.

Soon, we should talk strategy on getting either multiple build jobs for the different resource sets, or multi-output build jobs.
Attachment #8485337 - Flags: review?(nalexander) → review+
(In reply to Nick Alexander :nalexander from comment #4)

> I agree with mfinkle: consider a fine-grained fonts guard that is set by the
> coarser resource constrained guard.  I'm not too concerned either way.

Did do so. The important stanza is:

+MOZ_ARG_DISABLE_BOOL(android-include-fonts,
+[  --disable-android-include-fonts
+                          disable the inclusion of fonts into the final APK],
+    MOZ_ANDROID_EXCLUDE_FONTS=1)
+
+if test -n "$MOZ_ANDROID_EXCLUDE_FONTS"; then
+    AC_DEFINE(MOZ_ANDROID_EXCLUDE_FONTS, $MOZ_ANDROID_EXCLUDE_FONTS)
+    AC_SUBST(MOZ_ANDROID_EXCLUDE_FONTS)
+fi
+
https://hg.mozilla.org/mozilla-central/rev/b1821478bc41
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Summary: Exclude fonts and other large, optional resources from resource-limited builds → Add a build flag to exclude fonts from Android builds
Blocks: 1175555
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 35 → mozilla35
You need to log in before you can comment on or make changes to this bug.