1063868 - Add a build flag to exclude fonts from Android builds

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Exclude fonts from constrained APKs. v1

This change alone cuts our APK size by 2.75MB.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8485337 [details] [diff] [review]
Exclude fonts from constrained APKs. v1

I wouldn't mind being more specific with the flag here. We might also use this code for packaging GeckoView too.

Maybe change:
MOZ_ANDROID_RESOURCE_CONSTRAINED

to:
MOZ_ANDROID_BUNDLE_FONTS

And then also set MOZ_ANDROID_BUNDLE_FONTS when building a resource constrained APK.

Comment 3

[Richard Newman [:rnewman]]

https://tbpl.mozilla.org/?tree=Try&rev=5cff1d0270f1

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8485337 [details] [diff] [review]
Exclude fonts from constrained APKs. v1

Review of attachment 8485337 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this lagged; I thought I cleared it but it was in a background tab.

I agree with mfinkle: consider a fine-grained fonts guard that is set by the coarser resource constrained guard.  I'm not too concerned either way.

Soon, we should talk strategy on getting either multiple build jobs for the different resource sets, or multi-output build jobs.

Comment 5

[Richard Newman [:rnewman]]

(In reply to Nick Alexander :nalexander from comment #4)

> I agree with mfinkle: consider a fine-grained fonts guard that is set by the
> coarser resource constrained guard.  I'm not too concerned either way.

Did do so. The important stanza is:

+MOZ_ARG_DISABLE_BOOL(android-include-fonts,
+[  --disable-android-include-fonts
+                          disable the inclusion of fonts into the final APK],
+    MOZ_ANDROID_EXCLUDE_FONTS=1)
+
+if test -n "$MOZ_ANDROID_EXCLUDE_FONTS"; then
+    AC_DEFINE(MOZ_ANDROID_EXCLUDE_FONTS, $MOZ_ANDROID_EXCLUDE_FONTS)
+    AC_SUBST(MOZ_ANDROID_EXCLUDE_FONTS)
+fi
+

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/b1821478bc41

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1821478bc41

Comment 8

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bbe405fc142

Comment 9

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7a835837ede