Closed Bug 1063873 Opened 6 years ago Closed 1 year ago

Ship the right libomxplugin files for supported API ranges

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set
normal

Tracking

(fennec+)

RESOLVED FIXED
Tracking Status
fennec + ---

People

(Reporter: rnewman, Unassigned)

References

Details

AndroidMediaPluginHost demonstrates the logic. We should only ship files in the built APK's supported range. (And ideally conditionalize here, too.)


  if (version >= 17) {
    return "libomxpluginkk.so";
  }
  else if (version == 13 || version == 12 || version == 11) {
    return "libomxpluginhc.so";
  }
  else if (version == 10 && release_version >= NS_LITERAL_STRING("2.3.6")) {
    // Gingerbread versions from 2.3.6 and above have a different DataSource
    // layout to those on 2.3.5 and below.
    return "libomxplugingb.so";
  }
  else if (version == 10 && release_version >= NS_LITERAL_STRING("2.3.4") &&
           device.Find("HTC") == 0) {
    // HTC devices running Gingerbread 2.3.4+ (HTC Desire HD, HTC Evo Design, etc) seem to
    // use a newer version of Gingerbread libstagefright than other 2.3.4 devices.
    return "libomxplugingb.so";
  }
  else if (version == 9 || (version == 10 && release_version <= NS_LITERAL_STRING("2.3.5"))) {
    // Gingerbread versions from 2.3.5 and below have a different DataSource
    // than 2.3.6 and above.
    return "libomxplugingb235.so";
  }
  else if (version == 8) {
    // Froyo
    return "libomxpluginfroyo.so";
  }
  else if (version < 8) {
    // Below Froyo not supported
    return nullptr;
  }
tracking-fennec: --- → 36+
tracking-fennec: 36+ → 35+
If we fix bug 1093815 we can drop it entirely for 4.1 and higher.
Depends on: 1093815
tracking-fennec: 35+ → 36+
Shifting this back to make sure we get experience on Beta and Release: Bug 1120762.
tracking-fennec: 36+ → 38+
Depends on: 1120762
Assignee: nobody → rnewman
tracking-fennec: 38+ → +
Assignee: rnewman → nobody
Product: Firefox for Android → Firefox Build System

We no longer ship the OMX plugin.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.