1063883 - OMX h.264 encoder doesn't handle resolution changes in mid-stream

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

[Blocking Requested - why for this release]: blocks 2.0+ bug/patch landing

+++ This bug was initially created as a clone of Bug #1059765 +++

The OMX H.264 encoder reconfigures on a resolution change, but:
1) in contrast to stream start, it merges SPS/PPS/iframe in one buffer
2) it doesn't set the CODECCONFIG flag on the single-buffer SPS/PPS/iframe
3) if the size isn't a multiple of 16 in both dimensions, green (or maybe random) is inserted

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: In H.264 OMX HW make resolution changes work (SPS/PPS/iframe in one buffer)

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: use multiples of macroblocks for qm_select downscaling

focused on OMX h.264; it may be useful for allowing downscales while avoiding odd resolutions (and we should also look to see if that odd requirement can be relaxed now)

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8485360 [details] [diff] [review]
use multiples of macroblocks for qm_select downscaling

I'll take either reviewer for both patches

Comment 4

[Paul Kerr [:pkerr]]

You may want to create a bug to keep track of your embedded comments about using the divisor to handle odd frame sizes for other codecs, etc.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8413ea2576db
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bc9be7da066

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8413ea2576db
https://hg.mozilla.org/mozilla-central/rev/1bc9be7da066

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8485356 [details] [diff] [review]
In H.264 OMX HW make resolution changes work (SPS/PPS/iframe in one buffer)

This is for both patches on this bug (without the "force to macroblock boundary, when 320x240 is cut to 240x180, you end up with a stripe of green on the edge.  with the patch it goes to 256x192 and has no stripe.

We need it on Aurora/34 for 2.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): H.264 OMX

User impact if declined: inability to enable the content analysis for h.264, especially to allow the quality to track bandwidth available.

Testing completed: Tested here and by Jay Wang at QC

Risk to taking this patch (and alternatives if risky): We'd have to simply disable the resolution changes part of it (and leave fps adjustment only), which if bandwidth dropped to ~100K/s might cause quality to suffer a lot and/or frames per second to drop to annoying levels.

String or UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/25aeed7e96fa
https://hg.mozilla.org/releases/mozilla-aurora/rev/b0af000f6c88

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/38ccca82bd69
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/de70f9a40834

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/38ccca82bd69
http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/de70f9a40834