1063893 - Casting video is disabled on Beta

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: enable-casting v0.1

We never removed the build flag:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#285

We'll need to make a new beta at the earliest possible time.

This simple, low risk patch needs to be uplifted to aurora and beta.

Comment 1

[Richard Newman [:rnewman]]

Checkin-needed for m-c, even though it won't have a visible effect there.

Comment 2

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/b875e1449d67

Comment 3

[Richard Newman [:rnewman]]

I was landing something anyway, so bombs away.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8485370 [details] [diff] [review]
enable-casting v0.1

This has no real change for Aurora, but needs to ride the trains. Enabling for Beta was the expectation of everyone (Product, Dev, QA, etc) so I am approving to make sure we get this in the the next Beta build with all due haste.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2fd01375c79f
https://hg.mozilla.org/releases/mozilla-beta/rev/32560f800b2e

Comment 6

[Aaron Train [:aaronmt]]

Anything else in screen-casting behind a #ifdef RELEASE_BUILD that shouldn't?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Nothing unexpected. We use this only other one to change the name of the expected Roku app:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/RokuApp.jsm#27

We have one Roku app for Nightly/Aurora and a different one for Beta/Release.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b875e1449d67

Comment 9

[Flaviu Cos]

Verified as fixed in builds:
- 35.0a1 (2014-09-08);
- 34.0a1 (2014-09-08);
- 33 beta 2;
Device: Google Nexus 7 (Android 4.4.4).

Comment 11

[Stefan Deiac]

Based on comment 9 I will remove qe-verify flag.