Closed Bug 1063893 Opened 5 years ago Closed 5 years ago

Casting video is disabled on Beta

Categories

(Firefox for Android :: Screencasting, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 35
Tracking Status
firefox33 --- verified
firefox34 --- verified
firefox35 --- verified
fennec 33+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(1 file)

We never removed the build flag:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#285

We'll need to make a new beta at the earliest possible time.

This simple, low risk patch needs to be uplifted to aurora and beta.
Attachment #8485370 - Flags: review?(rnewman)
Attachment #8485370 - Flags: approval-mozilla-beta?
Attachment #8485370 - Flags: approval-mozilla-aurora?
Attachment #8485370 - Flags: review?(rnewman) → review+
Checkin-needed for m-c, even though it won't have a visible effect there.
Assignee: nobody → mark.finkle
Status: NEW → ASSIGNED
Keywords: checkin-needed
OS: Linux → Android
Hardware: x86_64 → All
tracking-fennec: --- → 33+
I was landing something anyway, so bombs away.
Keywords: checkin-needed
Comment on attachment 8485370 [details] [diff] [review]
enable-casting v0.1

This has no real change for Aurora, but needs to ride the trains. Enabling for Beta was the expectation of everyone (Product, Dev, QA, etc) so I am approving to make sure we get this in the the next Beta build with all due haste.
Attachment #8485370 - Flags: approval-mozilla-beta?
Attachment #8485370 - Flags: approval-mozilla-beta+
Attachment #8485370 - Flags: approval-mozilla-aurora?
Attachment #8485370 - Flags: approval-mozilla-aurora+
Anything else in screen-casting behind a #ifdef RELEASE_BUILD that shouldn't?
Nothing unexpected. We use this only other one to change the name of the expected Roku app:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/RokuApp.jsm#27

We have one Roku app for Nightly/Aurora and a different one for Beta/Release.
https://hg.mozilla.org/mozilla-central/rev/b875e1449d67
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Flags: qe-verify+
Verified as fixed in builds:
- 35.0a1 (2014-09-08);
- 34.0a1 (2014-09-08);
- 33 beta 2;
Device: Google Nexus 7 (Android 4.4.4).
Duplicate of this bug: 1063956
Based on comment 9 I will remove qe-verify flag.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.