1063896 - Regression: missing thumbnails in top sites; thumbnails replaced with tiny Favicons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Monreal [:micmon]]

When I switched to Aurora 33, all my "top sites" thumbs were replaced by small site icons. At the time I thought this was a feature. Now, on Aurora 34, one of the sites again has a thumb but the other five do not which looks strange.

I found similar bugs like #756881 but they all seem to be fixed in Aurora 34.

Comment 1

[Michael Monreal [:micmon]]

Attachment: Screenshot_2014-09-04-07-39-05.png

Here's a screenshot. The page that now works again is

http://www.androidpolice.com/

The pages that still do not show a thumb are

http://blog.fefe.de/
http://www.spiegel.de/
http://phandroid.com/
http://androidandme.com/
http://worldofgnome.org/

Comment 2

[Michael Monreal [:micmon]]

The above report is about Firefox on my Nexus 5. On my Nexus 7 the thumbs also disappears but even after updating to Aurora 34 the Androidpolice thumb is still gone.

Comment 3

[Richard Newman [:rnewman]]

Do the thumbnails come back when you visit the site?

When you visit those sites, do they redirect to a mobile version or a different URL? E.g., adding https, m. prefix, etc.

Comment 4

[Michael Monreal [:micmon]]

>> Do the thumbnails come back when you visit the site?

No, I visited all the pages a number of times but still only androidpolice shows the thumb.

>> When you visit those sites, do they redirect to a mobile version or a different URL?

No, some of them (not all) show a mobile layout but the URL stays the same.

Comment 5

[Lucas Rocha (:lucasr)]

wesj, maybe this is related to the work you've done around site images?

Comment 7

[Aaron Train [:aaronmt]]

According to the dupe above, on update from 32 to 33 all items in top-sites were replaced with generic globe icons

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Regression

Comment 9

[Aaron Train [:aaronmt]]

Findings

'Small Favicon' instead of the site thumbnail issue

  Load http://androidpolice.com
  Check on about:home, see tiny Favicon instead of site thumbnail (akin to the open tab in the drawer)

Last good revision: 869971ad9fd6 (2014-07-16)
First bad revision: a74600665875 (2014-07-17)

Pushlog:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=869971ad9fd6&tochange=a74600665875

Which yields us: 

0814bb0f08d0	Wes Johnston — Bug 1014712 - Store ms tile image information for showing on about:home. r=rnewman,lucasr

I'm not sure if this is also causing the Globe issue too.

Comment 10

[Wesley Johnston (:wesj)]

Attachment: Patch

This was dumbness on my part. We're looping over only the urls that our metadata table returned instead of over all of our requested urls. That means that urls where nothing was returned are basically ignored and wind up falling back to their favicon.

This loops over all the urls.

Comment 11

[Lucas Rocha (:lucasr)]

Comment on attachment 8489694 [details] [diff] [review]
Patch

Review of attachment 8489694 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 12

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/2494d16f6cae

Comment 13

[Wesley Johnston (:wesj)]

Comment on attachment 8489694 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1014712
[User impact if declined]: thumbnails aren't shown even though we have them. We always wind up showing favicons that look awful
[Describe test coverage new/current, TBPL]: none :(
[Risks and why]: Pretty low risk. The loops here already have fallbacks in place for things without metadata, we just weren't hitting it as often as we should.
[String/UUID change made/needed]: none.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2494d16f6cae

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/724b56b852ef
https://hg.mozilla.org/releases/mozilla-beta/rev/792d0824a8f0

Comment 16

[Michael Monreal [:micmon]]

I can confirm that after the fix landed all but one thumb appeared. For one page (http://www.spiegel.de/) I only see white with one thin vertical line. Should I file a new bug?

Comment 17

[Kevin Brosnan [Ex-Mozilla]]

I don't see that. Using Firefox Nighty or Beta. On http://www.spiegel.de/ or their mobile site.

Comment 18

[Michael Monreal [:micmon]]

Attachment: Screenshot_2014-09-29-20-07-03.png

This is how it looks for me. I removed and re-added the page, still the same.