Closed
Bug 1063957
Opened 10 years ago
Closed 10 years ago
Menu listing device access by websites empty if string for device set missing
Categories
(Firefox :: Keyboard Navigation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox35 | --- | verified |
People
(Reporter: aryx, Assigned: florian)
References
Details
Attachments
(1 file)
3.15 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Firefox Nightly and Aurora 20140906 on Windows 8.1 If a user grants a website access to e.g. a windows and a camera, the menu listing the device access by websites remains empty because the string needed for that permission is missing. NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.formatStringFromName] XStringBundle:37 Steps to reproduce: 1. Set media.getusermedia.screensharing.allowed_domains to mozilla.github.io,queze.net 2. Visit http://queze.net/goinfre/ff_gum_test.html 3. Click on 'Window then Video'. 4. Grant access to a window and a video source. 5. Open the menu which should list the access permissions. Actual result: It is empty and the error thrown. Bug 1043372 added strings for some sets of device permissions, but the combination window + camera is not in these strings.
Assignee | ||
Comment 1•10 years ago
|
||
Unfortunate that we didn't catch this before the merge of 34 to aurora, but sharing the camera and a {screen,window,app} without sharing the microphone at the same time is such an edge case that I don't think it's worth trying to figure out a way to fix this on aurora.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8486390 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Updated•10 years ago
|
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog+
Comment 2•10 years ago
|
||
Comment on attachment 8486390 [details] [diff] [review] Patch Review of attachment 8486390 [details] [diff] [review]: ----------------------------------------------------------------- rs=me Could do a try catch at least on Aurora so we don't have an empty menu, which kind of sucks?
Attachment #8486390 -
Flags: review?(gijskruitbosch+bugs) → review+
Updated•10 years ago
|
Iteration: --- → 35.1
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #2) > Could do a try catch at least on Aurora so we don't have an empty menu, > which kind of sucks? If this was the only item, we would likely still have an empty menu.
Comment 4•10 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #3) > (In reply to :Gijs Kruitbosch from comment #2) > > > Could do a try catch at least on Aurora so we don't have an empty menu, > > which kind of sucks? > > If this was the only item, we would likely still have an empty menu. Hrmpf. Can we lie and make camera + something else imply microphone is shared as well? I'd rather have the code be broken that way than not showing anything...
Updated•10 years ago
|
QA Contact: drno
Comment 5•10 years ago
|
||
Hi Florian, is this bug still a priority for IT 35.2 or can it be removed?
Flags: needinfo?(florian)
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Marco Mucci [:MarcoM] from comment #5) > Hi Florian, is this bug still a priority for IT 35.2 or can it be removed? The patch here is ready, I just need to do a check-in.
Flags: needinfo?(florian)
Updated•10 years ago
|
Iteration: 35.1 → 35.2
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c66eb4cb7d29
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c66eb4cb7d29
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Archaeopteryx [:aryx] from comment #0) > Steps to reproduce: > 2. Visit http://queze.net/goinfre/ff_gum_test.html Screen sharing now requires https. Use https://people.mozilla.org/~fqueze2/webrtc/ff_gum_test.html instead.
Comment 10•10 years ago
|
||
I was able to reproduce this issue on Firefox 35.0a1 (2014-09-06) using Windows 8.1 x64. Verified fixed on Latest Firefox 35.0a2 (2014-11-24) using Windows 8.1 x64.
Status: RESOLVED → VERIFIED
status-firefox35:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•