Closed Bug 1063957 Opened 10 years ago Closed 10 years ago

Menu listing device access by websites empty if string for device set missing

Categories

(Firefox :: Keyboard Navigation, defect)

x86_64
Windows 8.1
defect
Not set
normal
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 35
Iteration:
35.2
Tracking Status
firefox35 --- verified

People

(Reporter: aryx, Assigned: florian)

References

Details

Attachments

(1 file)

Firefox Nightly and Aurora 20140906 on Windows 8.1

If a user grants a website access to e.g. a windows and a camera, the menu listing the device access by websites remains empty because the string needed for that permission is missing.

NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.formatStringFromName] XStringBundle:37

Steps to reproduce:
1. Set media.getusermedia.screensharing.allowed_domains to mozilla.github.io,queze.net
2. Visit http://queze.net/goinfre/ff_gum_test.html
3. Click on 'Window then Video'.
4. Grant access to a window and a video source.
5. Open the menu which should list the access permissions.
Actual result: It is empty and the error thrown.

Bug 1043372 added strings for some sets of device permissions, but the combination window + camera is not in these strings.
Attached patch PatchSplinter Review
Unfortunate that we didn't catch this before the merge of 34 to aurora, but sharing the camera and a {screen,window,app} without sharing the microphone at the same time is such an edge case that I don't think it's worth trying to figure out a way to fix this on aurora.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8486390 - Flags: review?(gijskruitbosch+bugs)
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog+
Comment on attachment 8486390 [details] [diff] [review]
Patch

Review of attachment 8486390 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Could do a try catch at least on Aurora so we don't have an empty menu, which kind of sucks?
Attachment #8486390 - Flags: review?(gijskruitbosch+bugs) → review+
Iteration: --- → 35.1
(In reply to :Gijs Kruitbosch from comment #2)

> Could do a try catch at least on Aurora so we don't have an empty menu,
> which kind of sucks?

If this was the only item, we would likely still have an empty menu.
(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> 
> > Could do a try catch at least on Aurora so we don't have an empty menu,
> > which kind of sucks?
> 
> If this was the only item, we would likely still have an empty menu.

Hrmpf. Can we lie and make camera + something else imply microphone is shared as well? I'd rather have the code be broken that way than not showing anything...
Depends on: 1064909
QA Contact: drno
Hi Florian, is this bug still a priority for IT 35.2 or can it be removed?
Flags: needinfo?(florian)
(In reply to Marco Mucci [:MarcoM] from comment #5)
> Hi Florian, is this bug still a priority for IT 35.2 or can it be removed?

The patch here is ready, I just need to do a check-in.
Flags: needinfo?(florian)
Iteration: 35.1 → 35.2
https://hg.mozilla.org/mozilla-central/rev/c66eb4cb7d29
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
(In reply to Archaeopteryx [:aryx] from comment #0)

> Steps to reproduce:

> 2. Visit http://queze.net/goinfre/ff_gum_test.html

Screen sharing now requires https. Use https://people.mozilla.org/~fqueze2/webrtc/ff_gum_test.html instead.
I was able to reproduce this issue on Firefox 35.0a1 (2014-09-06) using Windows 8.1 x64.

Verified fixed on Latest Firefox 35.0a2 (2014-11-24) using Windows 8.1 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.