Closed Bug 1064038 Opened 10 years ago Closed 10 years ago

Handle errors for About Feedback form submission

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 36

People

(Reporter: vivek, Assigned: vivek, Mentored)

References

Details

Attachments

(1 file)

1064038.patch
2.04 KB, patch
Margaret
: review+
Details | Diff | Splinter Review 
      No description provided.
about:feedback form submission lacks error handling mentioned in the https://bugzilla.mozilla.org/show_bug.cgi?id=799562#c22.

This bug tracks the changes related to that.
Summary: Handle errors for About → Handle errors for About Feedback form submission
Assignee: nobody → vivekb.balakrishnan
Mentor: margaret.leibovic
Depends on: 799562
Status: NEW → ASSIGNED
Attached patch 1064038.patch — — Splinter Review 
Patch handles & honors the max length for user provided field namely description and the URL. The length of URL is truncated to max 200 char in JS when it is retrieved.
Attachment #8508049 - Flags: review?(margaret.leibovic)
Comment on attachment 8508049 [details] [diff] [review]
1064038.patch

Review of attachment 8508049 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #8508049 - Flags: review?(margaret.leibovic) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ff9ad5e9c815
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: