Closed Bug 1064084 Opened 10 years ago Closed 10 years ago

Convert all consumers of gfxContext transform related methods to exclusively use gfxContext::SetMatrix()/Multiply()

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla35

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(5 files, 3 obsolete files)

Translate() 10 years ago Jonathan Watt [:jwatt] 24.26 KB, patch		Details \| Diff \| Splinter Review
Scale() 10 years ago Jonathan Watt [:jwatt] 4.58 KB, patch	bas.schouten : review+	Details \| Diff \| Splinter Review
Rotate() 10 years ago Jonathan Watt [:jwatt] 1.87 KB, patch	bas.schouten : review+	Details \| Diff \| Splinter Review
IdentityMatrix() 10 years ago Jonathan Watt [:jwatt] 12.25 KB, patch	bas.schouten : review+	Details \| Diff \| Splinter Review
NudgeCurrentMatrixToIntegers() and MultiplyAndNudgeToIntegers() 10 years ago Jonathan Watt [:jwatt] 5.21 KB, patch	bas.schouten : review+	Details \| Diff \| Splinter Review
Translate() 10 years ago Jonathan Watt [:jwatt] 29.49 KB, patch		Details \| Diff \| Splinter Review
Translate() 10 years ago Jonathan Watt [:jwatt] 32.53 KB, patch	bas.schouten : review+	Details \| Diff \| Splinter Review
Scale() 10 years ago Jonathan Watt [:jwatt] 2.50 KB, patch	bas.schouten : review+	Details \| Diff \| Splinter Review

Jonathan Watt [:jwatt]

Assignee

Description

•

10 years ago

To fix bug 1064055 my plan is to first get us to the point where all non-DrawTarget using consumers are using only gfxContext::SetMatrix() and gfxContext::Multiply(). We can then much more easily convert the consumers of those methods to use the Moz2D API all in one go, avoiding issues like bug 1060762.

Jonathan Watt [:jwatt]

Assignee

Updated

•

10 years ago

Blocks: 1064056

Jonathan Watt [:jwatt]

Assignee

Updated

•

10 years ago

No longer blocks: 1064056

Depends on: 1064056

Keywords: perf

Jonathan Watt [:jwatt]

Assignee

Comment 1

•

10 years ago

Attached patch Translate() (obsolete) — Details — Splinter Review

Attachment #8485541 - Flags: review?(bas)

Jonathan Watt [:jwatt]

Assignee

Comment 2

•

10 years ago

Attached patch Scale() (obsolete) — Details — Splinter Review

Attachment #8485542 - Flags: review?(bas)

Jonathan Watt [:jwatt]

Assignee

Comment 3

•

10 years ago

Attached patch Rotate() — Details — Splinter Review

Attachment #8485543 - Flags: review?(bas)

Jonathan Watt [:jwatt]

Assignee

Comment 4

•

10 years ago

Attached patch IdentityMatrix() — Details — Splinter Review

Attachment #8485544 - Flags: review?(bas)

Jonathan Watt [:jwatt]

Assignee

Comment 5

•

10 years ago

Attached patch NudgeCurrentMatrixToIntegers() and MultiplyAndNudgeToIntegers() — Details — Splinter Review

Attachment #8485545 - Flags: review?(bas)

Jonathan Watt [:jwatt]

Assignee

Comment 6

•

10 years ago

Attached patch Translate() (obsolete) — Details — Splinter Review

Attachment #8485541 - Attachment is obsolete: true

Attachment #8485541 - Flags: review?(bas)

Attachment #8487572 - Flags: review?(bas)

Jonathan Watt [:jwatt]

Assignee

Comment 7

•

10 years ago

Attached patch Translate() — Details — Splinter Review

Attachment #8487572 - Attachment is obsolete: true

Attachment #8487572 - Flags: review?(bas)

Attachment #8487583 - Flags: review?(bas)

Bas Schouten (:bas.schouten)

Updated

•

10 years ago

Attachment #8487583 - Flags: review?(bas) → review+

Jonathan Watt [:jwatt]

Assignee

Comment 8

•

10 years ago

Attached patch Scale() — Details — Splinter Review

Attachment #8487587 - Flags: review?(bas)

Bas Schouten (:bas.schouten)

Updated

•

10 years ago

Attachment #8485542 - Flags: review?(bas) → review+

Bas Schouten (:bas.schouten)

Updated

•

10 years ago

Attachment #8485543 - Flags: review?(bas) → review+

Bas Schouten (:bas.schouten)

Updated

•

10 years ago

Attachment #8487587 - Flags: review?(bas) → review+

Bas Schouten (:bas.schouten)

Updated

•

10 years ago

Attachment #8485544 - Flags: review?(bas) → review+

Bas Schouten (:bas.schouten)

Updated

•

10 years ago

Attachment #8485545 - Flags: review?(bas) → review+

Jonathan Watt [:jwatt]

Assignee

Updated

•

10 years ago

Attachment #8485542 - Attachment is obsolete: true

Jonathan Watt [:jwatt]

Assignee

Comment 9

•

10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/01cd9a72cf48
https://hg.mozilla.org/integration/mozilla-inbound/rev/bed7d212a2cd
https://hg.mozilla.org/integration/mozilla-inbound/rev/7073e67f15be
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a70fe57a15d
https://hg.mozilla.org/integration/mozilla-inbound/rev/5db436c928aa

Carsten Book [:Tomcat]

Comment 10

•

10 years ago

https://hg.mozilla.org/mozilla-central/rev/01cd9a72cf48
https://hg.mozilla.org/mozilla-central/rev/bed7d212a2cd
https://hg.mozilla.org/mozilla-central/rev/7073e67f15be
https://hg.mozilla.org/mozilla-central/rev/8a70fe57a15d
https://hg.mozilla.org/mozilla-central/rev/5db436c928aa

Status: NEW → RESOLVED

Closed: 10 years ago

Resolution: --- → FIXED

Target Milestone: --- → mozilla35

Jonathan Watt [:jwatt]

Assignee

Updated

•

10 years ago

Blocks: 1087958

You need to log in before you can comment on or make changes to this bug.