Listen for wake_notification to evaluate whether to sync

RESOLVED FIXED in mozilla35

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
mozilla35
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

4 years ago
Follow-on from Bug 1064122.

The idle service isn't enough.

This won't work on Linux, but ¯\_(ツ)_/¯
(Assignee)

Comment 1

4 years ago
Created attachment 8485581 [details] [diff] [review]
Listen for wake_notification to evaluate whether to sync. v1

This ought to work.
(Assignee)

Updated

4 years ago
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Whiteboard: [qa?]
(Assignee)

Comment 3

4 years ago
Created attachment 8486573 [details] [diff] [review]
Listen for wake_notification to evaluate whether to sync. v1

(Feel free to treat this as f?; bzexport screws up feedback requests.)

xpcshell tests pass, though obviously there aren't new ones.

Not yet manually tested.

I'm open to suggestions about whether we should wait a while after waking to make sure the network is up.
Attachment #8486573 - Flags: review?(mhammond)
(Assignee)

Updated

4 years ago
Attachment #8485581 - Attachment is obsolete: true
(Assignee)

Comment 4

4 years ago
Created attachment 8486594 [details] [diff] [review]
Listen for wake_notification to evaluate whether to sync. v2

Now with observer added in the correct place!
Attachment #8486594 - Flags: review?(mhammond)
(Assignee)

Updated

4 years ago
Attachment #8486573 - Attachment is obsolete: true
Attachment #8486573 - Flags: review?(mhammond)
(Assignee)

Comment 5

4 years ago
Manually tested. ++
Will this need to be looked at from the desktop as well as the mobile client?
(Assignee)

Comment 7

4 years ago
This is a 100% desktop-only change.
Comment on attachment 8486594 [details] [diff] [review]
Listen for wake_notification to evaluate whether to sync. v2

Review of attachment 8486594 [details] [diff] [review]:
-----------------------------------------------------------------

TIL there is a wake_notification, but I like it :)
Attachment #8486594 - Flags: review?(mhammond) → review+
(Assignee)

Comment 10

4 years ago
Ready for QA on fx-team in 3, 2… :D
Flags: qe-verify+
Whiteboard: [qa?] → [qa+]
Removing my flag on the Whiteboard so I don't have to hear from the whiners...
Whiteboard: [qa+]
https://hg.mozilla.org/mozilla-central/rev/f5b0a8afb324
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.