Closed Bug 1064132 Opened 9 years ago Closed 9 years ago

Listen for wake_notification to evaluate whether to sync

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file, 2 obsolete files)

Listen for wake_notification to evaluate whether to sync. v2
2.79 KB, patch
markh
: review+
Details | Diff | Splinter Review 
Follow-on from Bug 1064122.

The idle service isn't enough.

This won't work on Linux, but ¯\_(ツ)_/¯
This ought to work.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Whiteboard: [qa?]
(Feel free to treat this as f?; bzexport screws up feedback requests.)

xpcshell tests pass, though obviously there aren't new ones.

Not yet manually tested.

I'm open to suggestions about whether we should wait a while after waking to make sure the network is up.
Attachment #8486573 - Flags: review?(mhammond)
Attachment #8485581 - Attachment is obsolete: true
Now with observer added in the correct place!
Attachment #8486594 - Flags: review?(mhammond)
Attachment #8486573 - Attachment is obsolete: true
Attachment #8486573 - Flags: review?(mhammond)
Manually tested. ++
Will this need to be looked at from the desktop as well as the mobile client?
This is a 100% desktop-only change.
Comment on attachment 8486594 [details] [diff] [review]
Listen for wake_notification to evaluate whether to sync. v2

Review of attachment 8486594 [details] [diff] [review]:
-----------------------------------------------------------------

TIL there is a wake_notification, but I like it :)
Attachment #8486594 - Flags: review?(mhammond) → review+
Ready for QA on fx-team in 3, 2… :D
Flags: qe-verify+
Whiteboard: [qa?] → [qa+]
Removing my flag on the Whiteboard so I don't have to hear from the whiners...
Whiteboard: [qa+]
https://hg.mozilla.org/mozilla-central/rev/f5b0a8afb324
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.