1064234 - [Contacts] When ICE contact's name is long, Setting menu isn't correctly visible

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Loli (:lolimartinezcr)]

Flame
2.1
Gecko-8a9db5d
Gaia-a8e4d26

Reproducible: 100%

STRs:
1. Tap contacts application.
2. Tap Settings button.
3. Tap "Set ICE Contacts" button.

Actual result:
It isn't correctly visible. See attached image.

Expected result:
It is correctly visible.

Comment 1

[Loli (:lolimartinezcr)]

Attachment: 2014-09-08-14-27-29.png

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Good catch :) thanks!

Comment 3

[Maria Angeles Oteo (:oteo)]

[Blocking Requested - why for this release]: Broken UI

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 23823

Comment 5

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8485994 [details] [review]
Pointer to PR 23823

Just a small comment in the PR, but r+ to me. Thanks Francisco!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8485994 [details] [review]
Pointer to PR 23823

Landed:

https://github.com/mozilla-b2g/gaia/commit/732163017ce8331d08685f059118dc3c3e0c8f86

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: not blocking since it's not very common to have such a long name.
We still want it to be fixed in 2.1 if the approval can be given.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Forgot to mark as fixed :S

Comment 9

[Loli (:lolimartinezcr)]

Tested and working
2.1
Gecko-52f8689
Gaia-d61264c

Comment 10

[Loli (:lolimartinezcr)]

(In reply to Loli (:lolimartinezcr) from comment #9)
> Tested and working
> 2.1
> Gecko-52f8689
> Gaia-d61264c

Although the patch has not uploaded  to 2.1, it's working

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

wow, that doesnt make much sense.

I've tried this in 2.2 (master) and it's working, also in 2.1 it's not working.

Loli can you try again?

Comment 12

[Loli (:lolimartinezcr)]

Attachment: 2014-09-11-13-10-49.png

Comment 13

[Loli (:lolimartinezcr)]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #11)
> wow, that doesnt make much sense.
> 
> I've tried this in 2.2 (master) and it's working, also in 2.1 it's not
> working.
> 
> Loli can you try again?
OK, not problem i try to test again

Comment 14

[Loli (:lolimartinezcr)]

(In reply to Loli (:lolimartinezcr) from comment #13)
> (In reply to Francisco Jordano [:arcturus] [:francisco] from comment #11)
> > wow, that doesnt make much sense.
> > 
> > I've tried this in 2.2 (master) and it's working, also in 2.1 it's not
> > working.
> > 
> > Loli can you try again?
> OK, not problem i try to test again

I have tested again with last version in 2.1 and *not working*. Last day I saw it working because it depends of incoming string in name 2014-09-11-13-10-49.png, but if i write other string it isn't working.

Comment 15

[Maria Angeles Oteo (:oteo)]

Thanks Loli! Francisco, can you ask for the approval?

Adding it to the meta bug 1026943

Comment 16

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.2
Gecko-713c41b
Gaia-32d82d2

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8485994 [details] [review]
Pointer to PR 23823

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Feature ICE
[User impact] if declined:
Bad user experience with long names, especially on countries like south america
[Testing completed]:
Test passed by QA
[Risk to taking this patch] (and alternatives if risky):
Low risk, small change in the ui to prevent the ugly effect
[String changes made]:

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/52b4d13a8f58ff20218aec749a8f55db0c22ea41

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Link to demo

Comment 20

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.1
Gecko:3953700
Gaia:713448b