Closed Bug 1064256 Opened 5 years ago Closed 5 years ago
Error: ice Group is null"
We get this error when we don't have any contact set as ICE. Easily reproducible when doing a make reset-gaia
Assignee: nobody → francisco
Comment on attachment 8485714 [details] [review] Pointer to PR 23805 Thanks Francisco! r+
Attachment #8485714 - Flags: review?(sergi.mansilla) → review+
Comment on attachment 8485714 [details] [review] Pointer to PR 23805 Hei Zac, had to modify the python ui tests, since we are creating now a new 'hidden' contact always that will lead us to the ICE section, when where selecting the number of contacts we were always having an extra one. Just modify the selector to avoid including this hidden new row in the contact list.
Attachment #8485714 - Flags: review?(zcampbell)
Attachment #8485714 - Flags: approval-gaia-v2.1?(bbajaj)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8485714 [details] [review] Pointer to PR 23805 Approving the landing as the risk looks manageable at this point in the release cycle and given the added test
Attachment #8485714 - Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
Reverted from v2.1 for Gaia unit test failures. v2.1: https://github.com/mozilla-b2g/gaia/commit/d3b1f6b47c8b18921a3a1bccbd2d4c0f4095d99b https://tbpl.mozilla.org/php/getParsedLog.php?id=48136420&tree=Mozilla-Aurora
Hi Ryan, something must have changed in our test harness, cause this was a problem on reseting the status of tests. I just did a patch for 2.1, this patch compared with 2.2 has a line different, doing that reset automatically. Could you uplift that one? Thanks!
Flags: needinfo?(francisco) → needinfo?(ryanvm)
I can't get this patch to apply. Can you just submit a pull request?
Flags: needinfo?(ryanvm) → needinfo?(francisco)
Will do, Thanks!
Nevermind, I figured it out. v2.1: https://github.com/mozilla-b2g/gaia/commit/d6e06fc7378c3d25618b0e1f99715a96fa290f61
Unfortunately will need to backout last commit. As was the same that was merged originaly and producing the error in unit tests: 941cc6c93a64875bf88eb38d7327fb35db0a6ae2
And pushed the specific 2.1 patch version https://github.com/mozilla-b2g/gaia/commit/987645cd189790e27ceb49497028ed32e8d00c90
You need to log in before you can comment on or make changes to this bug.