Closed
Bug 1064256
Opened 10 years ago
Closed 10 years ago
[Contacts] "TypeError: iceGroup is null"
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Firefox OS Graveyard
Gaia::Contacts
Tracking
(b2g-v2.1 fixed, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S4 (12sep)
People
(Reporter: arcturus, Assigned: arcturus)
Details
(Whiteboard: [p=1])
Attachments
(2 files)
46 bytes,
text/x-github-pull-request
|
sergi
:
review+
zcampbell
:
review+
bajaj
:
approval-gaia-v2.1+
|
Details | Review |
2.97 KB,
patch
|
Details | Diff | Splinter Review |
We get this error when we don't have any contact set as ICE. Easily reproducible when doing a make reset-gaia
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → francisco
Whiteboard: [p=1]
Comment 2•10 years ago
|
||
Comment on attachment 8485714 [details] [review] Pointer to PR 23805 Thanks Francisco! r+
Attachment #8485714 -
Flags: review?(sergi.mansilla) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8485714 [details] [review] Pointer to PR 23805 Hei Zac, had to modify the python ui tests, since we are creating now a new 'hidden' contact always that will lead us to the ICE section, when where selecting the number of contacts we were always having an extra one. Just modify the selector to avoid including this hidden new row in the contact list.
Attachment #8485714 -
Flags: review?(zcampbell)
Updated•10 years ago
|
Attachment #8485714 -
Flags: review?(zcampbell) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/84fe3093b81a6eb6f461b08f2e79aa9684b273fc Thanks!
Assignee | ||
Updated•10 years ago
|
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8485714 [details] [review] Pointer to PR 23805 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): ICE feature [User impact] if declined: We have a constant javascript error that can lead to major disfunction [Testing completed]: Smoke test, and more unit tests added to check this problem [Risk to taking this patch] (and alternatives if risky): Low, patchi is moving some lines above, and more unit test than proper patch [String changes made]:
Attachment #8485714 -
Flags: approval-gaia-v2.1?(bbajaj)
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 6•10 years ago
|
||
Comment on attachment 8485714 [details] [review] Pointer to PR 23805 Approving the landing as the risk looks manageable at this point in the release cycle and given the added test
Attachment #8485714 -
Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
Comment 7•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/186a163b0304dccc0ffc1918ae70c16c966291a0
Target Milestone: --- → 2.1 S4 (12sep)
Comment 8•10 years ago
|
||
Reverted from v2.1 for Gaia unit test failures. v2.1: https://github.com/mozilla-b2g/gaia/commit/d3b1f6b47c8b18921a3a1bccbd2d4c0f4095d99b https://tbpl.mozilla.org/php/getParsedLog.php?id=48136420&tree=Mozilla-Aurora
Assignee | ||
Comment 9•10 years ago
|
||
Hi Ryan, something must have changed in our test harness, cause this was a problem on reseting the status of tests. I just did a patch for 2.1, this patch compared with 2.2 has a line different, doing that reset automatically. Could you uplift that one? Thanks!
Flags: needinfo?(francisco) → needinfo?(ryanvm)
Comment 10•10 years ago
|
||
I can't get this patch to apply. Can you just submit a pull request?
Flags: needinfo?(ryanvm) → needinfo?(francisco)
Comment 12•10 years ago
|
||
Nevermind, I figured it out. v2.1: https://github.com/mozilla-b2g/gaia/commit/d6e06fc7378c3d25618b0e1f99715a96fa290f61
Keywords: branch-patch-needed
Assignee | ||
Comment 13•10 years ago
|
||
Unfortunately will need to backout last commit. As was the same that was merged originaly and producing the error in unit tests: 941cc6c93a64875bf88eb38d7327fb35db0a6ae2
Assignee | ||
Comment 14•10 years ago
|
||
And pushed the specific 2.1 patch version https://github.com/mozilla-b2g/gaia/commit/987645cd189790e27ceb49497028ed32e8d00c90
You need to log in
before you can comment on or make changes to this bug.
Description
•