1064256 - [Contacts] "TypeError: iceGroup is null"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

We get this error when we don't have any contact set as ICE.

Easily reproducible when doing a make reset-gaia

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 23805

Comment 2

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8485714 [details] [review]
Pointer to PR 23805

Thanks Francisco! r+

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8485714 [details] [review]
Pointer to PR 23805

Hei Zac,

had to modify the python ui tests, since we are creating now a new 'hidden' contact always that will lead us to the ICE section, when where selecting the number of contacts we were always having an extra one.

Just modify the selector to avoid including this hidden new row in the contact list.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/84fe3093b81a6eb6f461b08f2e79aa9684b273fc

Thanks!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8485714 [details] [review]
Pointer to PR 23805

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
ICE feature
[User impact] if declined:
We have a constant javascript error that can lead to major disfunction
[Testing completed]:
Smoke test, and more unit tests added to check this problem
[Risk to taking this patch] (and alternatives if risky):
Low, patchi is moving some lines above, and more unit test than proper patch
[String changes made]:

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 8485714 [details] [review]
Pointer to PR 23805

Approving the landing as the risk looks manageable at this point in the release cycle and given the added test

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/186a163b0304dccc0ffc1918ae70c16c966291a0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Reverted from v2.1 for Gaia unit test failures.
v2.1: https://github.com/mozilla-b2g/gaia/commit/d3b1f6b47c8b18921a3a1bccbd2d4c0f4095d99b

https://tbpl.mozilla.org/php/getParsedLog.php?id=48136420&tree=Mozilla-Aurora

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: bug-1064256-v21.patch

Hi Ryan,

something must have changed in our test harness, cause this was a problem on reseting the status of tests.

I just did a patch for 2.1, this patch compared with 2.2 has a line different, doing that reset automatically.

Could you uplift that one?

Thanks!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

I can't get this patch to apply. Can you just submit a pull request?

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Will do,

Thanks!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Nevermind, I figured it out.

v2.1: https://github.com/mozilla-b2g/gaia/commit/d6e06fc7378c3d25618b0e1f99715a96fa290f61

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Unfortunately will need to backout last commit. As was the same that was merged originaly and producing the error in unit tests:


941cc6c93a64875bf88eb38d7327fb35db0a6ae2

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

And pushed the specific 2.1 patch version

https://github.com/mozilla-b2g/gaia/commit/987645cd189790e27ceb49497028ed32e8d00c90