1064361 - Convert mainthread-only users of nsHashPropertyBag to nsHashPropertyBagCC

Status: NEW

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

nsHashPropertyBag uses threadsafe refcounting, which is needed for the various Necko subclasses, but there are various C++ users that may not need threadsafe refcounting.

When I glanced at this before, I didn't really understand what was going on, and the places that were using it seemed very thready (media and IPC) so I didn't look into it much more, but now that I look at it again, they seem to be using a common pattern where they create a bag, then use it to trigger it with the observer service.  Observer service is mainthread only, so these should be fine to convert.  On the other hand, I can't imagine performance being an issue for those uses.

Anyways, somebody should look over and see what we can convert.

Ideally, the threadsafe refcounting version should have a different name, but I'm not sure what it would be.  It still isn't really threadsafe, because it uses a non threadsafe hashtable, it just isn't mainthread only.