1064419 - [Contacts][Facebook] Facebook contacts imported without a profile picture displays incorrectly in Contacts app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Roland Kunkel [:RolandK]]

Attachment: screenshot

Description:
When the user imports Facebook contacts that do not have a profile picture, the generic icon displayed in the Contacts app appears cutoff and/or truncated

Repro Steps:
1) Update a Flame device to BuildID: 20140908040204
2) Connect to WiFi or enable Cellular data
3) Open Contacts > Settings > Sync Facebook Friends
4) Import Facebook contacts that do not have a profile picture
5) Open Contacts main page and observe contacts.
  
Actual:
Facebook contacts without a profile picture display incorrectly 
  
Expected: 
Facebook contacts without a profile picture display generic icon 
  
Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
  
Repro frequency: 100%
See attached: screenshot

Comment 1

[Roland Kunkel [:RolandK]]

This issue DOES occur in the latest 2.1 Flame build:

Environmental Variables:
Device: Flame 2.1
BuildID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Imported Facebook contacts without profile pictures are displayed incorrectly in the Contacts app.

Comment 2

[Peter Bylenga [:PBylenga]]

Not going to nominate to block release.  Facebook profiles without a photo are a rare user case, although this still is an inconsistent behavior and graphical issue it's low exposure.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

+1 to NOT nominate

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Can we get a regression range to at least know that it is contact app?  I'd rather not get this bug 6 weeks from now as a graphics bug, because it turns out it should be blocking a release.

Comment 5

[Jason Smith [:jsmith]]

Mentioned offline, but QA is not committed to supporting regression windows on non-blockers, since windows are expensive to conduct.

Comment 6

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Regression from bug 1043496

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8487806 [details]
Github pull request

Tried on the phone and looking perfect.

Great job as always Cristian!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8487806 [details]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
New default image feature
[User impact] if declined:
Bad user experience
[Testing completed]:
New unit tests added and smoke test
[Risk to taking this patch] (and alternatives if risky):
Pretty low, again adding and removing unnecessary css
[String changes made]:

Comment 9

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/28d81021a6ee79b9685645eb911444212b3e2ef7

Comment 10

[bhavana bajaj [:bajaj]]

Comment on attachment 8487806 [details]
Github pull request

Flagging QA to verify once this lands in 2.1

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/30b06ecd484e17e4a745b4d60b57dd6088f32732

Comment 12

[Duane Dixon [:ddixon]]

Issue is verified fixed in Flame 2.2, 2.1 (Full Flash, nightly). 

Actual Results: Imported Facebook contact with a generic picture displays correctly once imported. 

Device: Flame Master
Build ID: 20141014040203
Gaia: 4f86c631e0465c0e56ccebeb1324fd28be9ea32f
Gecko: 54217864bae9
Version: 36.0a1 (Master)
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1
Build ID: 20141014001201
Gaia: 7e2e65a9668123b54c8cce5dacfdba6f4bd4672b
Gecko: 2325da834971
Version: 34.0 (2.1)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0