Closed Bug 1064421 Opened 10 years ago Closed 10 years ago

Marionette setWindowSize support fixes

Categories

(Remote Protocol :: Marionette, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: rwood, Assigned: automatedtester)

References

Details

Attachments

(1 file, 1 obsolete file)

Create a new patch to address issues as noted in:

https://bugzilla.mozilla.org/show_bug.cgi?id=1045103#c19

I was originally set to review and had started it. Please can you raise a bug for us to fix the following issues

::: testing/marionette/client/marionette/tests/unit/test_set_window_size.py
@@ +21,5 @@
> +            self.start_size['width']-=1
> +        self.marionette.set_window_size(self.start_size['width'], self.start_size['height'])
> +        super(MarionetteTestCase, self).tearDown()
> +
> +    def test_set_window_size(self):

nit: can we have a slightly more descriptive name for the test. It doesn't suggest if it is a positive or negative test.

@@ +41,5 @@
> +                         "Window width is %s but should be %s" % (size['width'], width))
> +        self.assertEqual(size['height'], height,
> +                         "Window height is %s but should be %s" % (size['height'], height))
> +
> +        # invalid size (cannot maximize)

this looks like it would be different test so we should split it

::: testing/marionette/client/marionette/tests/unit/unit-tests.ini
@@ +124,1 @@
>  

this should be a Firefox only test since we can't update the window size on mobile

::: testing/marionette/marionette-server.js
@@ +2381,5 @@
> +   */
> +  setWindowSize: function MDA_setWindowSize(aRequest) {
> +    this.command_id = this.getCommandId();
> +
> +    if (appName == "B2G") {

It would be better if this was (appName !== "Firefox") that way we don't need to special case for fennec when we start supporting it
Whiteboard: [good first bug]
going to finish off some window bugs and will do this as part of it
Assignee: rwood → dburns
Whiteboard: [good first bug]
Attachment #8491732 - Flags: review?(jgriffin)
Attachment #8491732 - Attachment is obsolete: true
Attachment #8491732 - Flags: review?(jgriffin)
Attachment #8491803 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/ca7e71c15c4f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.