1064550 - Stop eating exceptions with a special JSErrorReporter in nsXPCWrappedJSClass::CallMethod

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

This is similar to bug 1062631, but happens in a different place. Maybe we'll get lucky and there won't be quite so many lurking exceptions that we'll need to deal with.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=5a0be05a4c0c

Comment 2

[Bobby Holley (:bholley)]

Attachment: Remove xpcWrappedJSErrorReporter. v1

Given that the JS engine always clears exceptions immediately after reporting
them, the empty body after JSREPORT_IS_EXCEPTION causes us to eat exceptions
here.

Comment 3

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (:bholley) from comment #0)
> Maybe
> we'll get lucky and there won't be quite so many lurking exceptions that
> we'll need to deal with.

(In reply to Bobby Holley (:bholley) from comment #1)
> https://tbpl.mozilla.org/?tree=Try&rev=5a0be05a4c0c

And lucky we seem to be. Rounding out the try push with a few more platforms: try: -b do -p win32,emulator,linux32_gecko -u all -t none

Comment 4

[Bobby Holley (:bholley)]

Er, meant to include the link in the previous comment: https://tbpl.mozilla.org/?tree=Try&rev=0b276abe079c

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8486100 [details] [diff] [review]
Remove xpcWrappedJSErrorReporter. v1

Hmm.  r=me, again assuming this doesn't cause tons of browser console spew.

Comment 6

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22eb7571af8e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22eb7571af8e