Closed Bug 1064550 Opened 8 years ago Closed 8 years ago

Stop eating exceptions with a special JSErrorReporter in nsXPCWrappedJSClass::CallMethod

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

This is similar to bug 1062631, but happens in a different place. Maybe we'll get lucky and there won't be quite so many lurking exceptions that we'll need to deal with.
Given that the JS engine always clears exceptions immediately after reporting
them, the empty body after JSREPORT_IS_EXCEPTION causes us to eat exceptions
here.
Attachment #8486100 - Flags: review?(bzbarsky)
(In reply to Bobby Holley (:bholley) from comment #0)
> Maybe
> we'll get lucky and there won't be quite so many lurking exceptions that
> we'll need to deal with.

(In reply to Bobby Holley (:bholley) from comment #1)
> https://tbpl.mozilla.org/?tree=Try&rev=5a0be05a4c0c

And lucky we seem to be. Rounding out the try push with a few more platforms: try: -b do -p win32,emulator,linux32_gecko -u all -t none
Er, meant to include the link in the previous comment: https://tbpl.mozilla.org/?tree=Try&rev=0b276abe079c
Comment on attachment 8486100 [details] [diff] [review]
Remove xpcWrappedJSErrorReporter. v1

Hmm.  r=me, again assuming this doesn't cause tons of browser console spew.
Attachment #8486100 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/22eb7571af8e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.