Closed
Bug 1064571
Opened 10 years ago
Closed 10 years ago
[RTL] Message recipient input should align and input RTL.
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(ux-b2g:2.2)
RESOLVED
DUPLICATE
of bug 1053708
ux-b2g | 2.2 |
People
(Reporter: swilkes, Unassigned)
References
Details
(Whiteboard: [2.1-Arabic-RTL-bug-bash])
Set language to Arabic. Open the SMS composer. Observe that + icon to add contact and blue bubble input are aligned left. Expected: + icon and bubble input are aligned right, and recipient name in Arabic (when there is a keyboard to type in Arabic, which there isn't yet) should flow from RTL when input.
Comment 1•10 years ago
|
||
Stephany, I agree that bubble input should be aligned right, but why the "+" icon should be aligned right like in LTR situation? I don't get why it should not be aligned left in RTL.
Flags: needinfo?(swilkes)
Reporter | ||
Comment 2•10 years ago
|
||
This bug was added to our Arabic Bug Bash etherpad by one of our users in either Tunis, Jordan or Sudan. I can try to figure out who it was, but I'm just filing what they found and added during the Arabic community bug bash. They said this is what they would expect to see.
Flags: needinfo?(swilkes)
Comment 3•10 years ago
|
||
Ahmed, I think we need your insight here :) Can you please comment on my question in comment 1?
Flags: needinfo?(nefzaoui.ahmed)
Comment 4•10 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #1) > Stephany, I agree that bubble input should be aligned right, but why the "+" > icon should be aligned right like in LTR situation? I don't get why it > should not be aligned left in RTL. I agree, the "+" icon should be left-aligned in RTL as it is right now, which is the most reasonable thing to do IMO given its original position in LTR. :) I'm guessing that the "bubble input" is the input position indicator bubble? If so I think it should be addressed on gecko's side while the text auto-alignment should be addressed in gaia using the :dir(ltr/rtl) pseudo-class right?
Flags: needinfo?(nefzaoui.ahmed)
Comment 5•10 years ago
|
||
I'd like to double check but I think we're using "float" to float the bubbles currently, maybe we should switch to inline-block so that it would work in RTL for free? Another possibility is to use flexible layout with flex-wrap. Could be quite elegant indeed :)
Reporter | ||
Updated•10 years ago
|
Whiteboard: [2.1-Arabic-RTL-bug-bash]
Comment 6•10 years ago
|
||
Except bug 1080832, I think this works fine now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Comment 7•10 years ago
|
||
Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15374/
Flags: in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•