1064587 - Cycle collect nsFormFillController

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Andrew McCreight [:mccr8]]

e10s M5 is leaking 10 TabChildren (along with nsDocShell, etc.), plus some other stuff.

I can reproduce this locally with the slightly smaller:
  ./mach mochitest-plain --e10s --total-chunks 10 --this-chunk 10

These TabChildren are all being rooted by various |nsXPCWrappedJS (nsIAutoCompletePopup)|.  The only C++ things I can see that hold onto that are fields of nsFormFillController, which is exposed to JS, so I could certainly imagine cycles involving it.  I'll try CCing it.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

What is keeping nsFormFillController alive?

Comment 2

[Andrew McCreight [:mccr8]]

Hmm, it is hard to tell just from the allocation stacks, because everything is just generic XPCOM stacks.  Some other XPCOM service it looks like?

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Cycle collect nsFormFillController.

Locally, this fixes the leaks in the test case in comment 0 (partial M5 e10s run).  I'll see what happens in an M5 e10s run.

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8486122 [details] [diff] [review]
Cycle collect nsFormFillController.

Just a generic cycle collection patch, so I think it is reasonable for smaug to review it.

try run: https://tbpl.mozilla.org/?tree=Try&rev=9156076fd279

Comment 5

[Andrew McCreight [:mccr8]]

There's a bunch of weak pointers that get cleared using mutation observers that I suppose could be turned into strong pointers now, but I just left it alone.

Comment 6

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/badb065c77ac

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/badb065c77ac