Closed Bug 1064592 Opened 5 years ago Closed 5 years ago

[RTL] Yahoo! should not appear as "!Yahoo" in Calendar > Add an Account.

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

x86
macOS
defect

Tracking

(feature-b2g:2.2+, ux-b2g:2.2, b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
2.2 S5 (6feb)
feature-b2g 2.2+
ux-b2g 2.2
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: swilkes, Assigned: autra)

References

Details

Attachments

(2 files)

Set language to Arabic. 
In "اضف حسابا ", Yahoo! appears as "!Yahoo." 

Expected: As a brand name, Yahoo! should remain Yahoo!.
We are going to treat "yahoo!" as a brandname similar to  firefoxOS and should not apply the localization to it. So we would need a quick patch to honor that case.
blocking-b2g: --- → 2.2+
Priority: -- → P1
Hi!

Here's a possible way to fix it. Not sure if it is the best way though. Other possible way would be to make every item in this list LTR, as I guess we won't add provider whose name is RTL in the near future :-)
Attachment #8554170 - Flags: review?(mmedeiros)
Comment on attachment 8554170 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27651

LGTM.
Attachment #8554170 - Flags: review?(mmedeiros) → review+
RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)
blocking-b2g: 2.2+ → ---
feature-b2g: --- → 2.2+
uplifted to 2.2: https://github.com/mozilla-b2g/gaia/commit/d84b280
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → augustin.trancart
Target Milestone: --- → 2.2 S5 (6feb)
This issue has verify successfully on latest Flame 2.2/3.0
Reproduce rate:0/5

Attachment:Verify_RTL_Yahoo.png

Flame 2.2 build:

Gaia-Rev        6e494f1d2676d231abba7dcc2e2822d1170d2d02
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5e6fac01a72f
Build-ID        20150129003432
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150129.042943
FW-Date         Thu Jan 29 04:29:53 EST 2015
Bootloader      L1TC000118D0

Flame 3.0 build:

Gaia-Rev        9d2378a9ef092ab1fc15c3a9f7fc4171aab59d57
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/6bfc0e1c4b29
Build-ID        20150129010239
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150129.043711
FW-Date         Thu Jan 29 04:37:21 EST 2015
Bootloader      L1TC000118D0
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
Attached image Verify_RTL_Yahoo.png
Flags: in-moztrap-
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15882/
Flags: in-moztrap- → in-moztrap+
You need to log in before you can comment on or make changes to this bug.