Closed Bug 1064699 Opened 5 years ago Closed 5 years ago

Update mLastVideoFrameTime after it's used for computing the frame duration

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The patch in bug 1062101 turns out to be incorrect because it sets mLastVideoFrameTime when it reads the packet tstamp, but as it's not used to compute the frame duration until slightly later, when it's finally used to compute the final frame's duration it ends up calculating a zero duration.

This partially explains the difference between the buffered range end time and the last decoded frame end time mentioned in bug 1062055.
Attached patch trivial fixSplinter Review
Attachment #8486228 - Flags: review?(cajbir.bugzilla)
Attachment #8486228 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/cf5b1e58fbb9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.