Closed Bug 1064776 Opened 5 years ago Closed 5 years ago

disable unified autocomplete for Firefox 34

Categories

(Firefox :: Address Bar, defect)

defect
Not set
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 34
Iteration:
35.1
Tracking Status
firefox33 --- unaffected
firefox34 + verified

People

(Reporter: Gavin, Assigned: mak)

References

Details

Attachments

(1 file)

See discussion starting at bug 1045985 comment 9.
I can take this. Marco please add to the current iteration.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog+
The primary driver for this is fixing bug 1045985. The main consequence is that we will lose the feature from bug 1034381.
Added to IT 35.1

(In reply to Marco Bonardo [:mak] (needinfo? me) from comment #1)
> I can take this. Marco please add to the current iteration.
Iteration: --- → 35.1
Comment on attachment 8486518 [details] [diff] [review]
patch v1

I thought I had already set the request :/
Attachment #8486518 - Flags: review?(ttaubert)
Attachment #8486518 - Flags: review?(ttaubert) → review+
Comment on attachment 8486518 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: Unified Complete
[User impact if declined]: the functionality is incomplete and provides an under-quality-standards experience in the awesomebar
[Describe test coverage new/current, TBPL]: usual test coverage for previous autocomplete
[Risks and why]: very low, this just restores the old autocomplete component
[String/UUID change made/needed]: none
Attachment #8486518 - Flags: approval-mozilla-aurora?
Attachment #8486518 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
thanks
https://hg.mozilla.org/releases/mozilla-aurora/rev/bc2efaa7ed16
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
QA Contact: alexandra.lucinet
QA Contact: alexandra.lucinet → andrei.vaida
Testing performed on Aurora 34.0a2 (2014-09-15), using Windows 7 64-bit, Mac OS X 10.9.4 and Ubuntu 14.04 LTS 64-bit.

Acceptance criteria:
- The Unified Autocomplete associated pref: "browser.urlbar.unifiedcomplete" is either removed from Fx34 or set to false by default.
- The awesomebar passes smoketesting, the suggestions and results pane are working as expected.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.