The default bug view has changed. See this FAQ.

Remove unnecessary CNG checks in some places

RESOLVED FIXED in mozilla35

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla35
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
After enabling Ion/TI everywhere (bug 939562) and Ion-compiling non-CNG functions (bug 1045529), there are still some performance problems in non-CNG (chrome) code caused by (unnecessary) CNG checks in various places. I'll post some patches to remove them, so that we can hopefully close the gap between content and chrome even more.
(Assignee)

Updated

3 years ago
Blocks: 916464
(Assignee)

Comment 1

3 years ago
Created attachment 8486320 [details] [diff] [review]
Part 1 - TypeScript::InitObject

This makes the addon in bug 911570 a lot faster.
Attachment #8486320 - Flags: review?(bhackett1024)
Attachment #8486320 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 2

3 years ago
Part 1:

https://hg.mozilla.org/integration/mozilla-inbound/rev/62e5db38c251
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/62e5db38c251
(Assignee)

Comment 4

3 years ago
Created attachment 8487820 [details] [diff] [review]
Part 2 - Definite properties and arguments analysis
Attachment #8487820 - Flags: review?(bhackett1024)
Attachment #8487820 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 5

3 years ago
Part 2:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4b3b9593d01
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/d4b3b9593d01
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.