Desktop client should cope with trailing slashes on loop.server pref

RESOLVED WORKSFORME

Status

Hello (Loop)
Client
P5
normal
RESOLVED WORKSFORME
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: cedric raudin, Mentored)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tech-debt][good first bug][lang=js])

(Reporter)

Description

3 years ago
Coming out of the comments on bug 1032738 (bug 1032738 comment 15 and onwards), it appears one of the errors was due to the loop.server preference being set with a trailing slash.

We should consider, for developer sanity, allowing preferences with trailing slashes.

At the moment, this would affect both the MozLoopService and MozLoopPushHandler modules.
(Reporter)

Updated

3 years ago
Whiteboard: [tech-debt]

Updated

3 years ago
backlog: --- → Fx36+

Updated

3 years ago
backlog: Fx36+ → Fx37+

Updated

3 years ago
Priority: -- → P1
Moving this to P2 based on our new priority definitions.
Priority: P1 → P2

Updated

3 years ago
backlog: Fx37+ → tech-debt
Priority: P2 → P5
(Reporter)

Comment 2

3 years ago
For developers:

- The places to start looking are for the loop.server prefs:

http://mxr.mozilla.org/mozilla-central/search?string=loop.server

- Currently things break when we add a trailing slash onto the end of the pref, so adding that and testing the Hello button on the toolbar should reveal any issues.

Note that for the push handler, this is the push notification service, so you'll either need to test receiving calls from another browser, or test entering a room with another browser/machine.
Mentor: standard8@mozilla.com
Whiteboard: [tech-debt] → [tech-debt][good first bug][lang=js]
(Assignee)

Comment 3

3 years ago
Hi,

Can I work on this bug?
(Reporter)

Comment 4

3 years ago
Yep, sure, assigning you to it.
Assignee: nobody → cedric.raudin
(Reporter)

Comment 5

3 years ago
Cedric pointed out to me offline, that the original issue that caused this bug to be filed is no longer present.

I suspect the recent server updates have somehow fixed this.

Whilst its a bit messy to have double-slashes in urls, I don't think it really matters in this case as it isn't our default mode of operating.

Therefore, I'm going to close this as works for me as we don't need it now.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
(Reporter)

Comment 6

3 years ago
and thanks to Cedric for testing it!
You need to log in before you can comment on or make changes to this bug.