Consider replacing the FilterNodeCompositeSoftware code with Skia compositing through DrawTargetSkia

ASSIGNED
Assigned to

Status

()

defect
ASSIGNED
5 years ago
3 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

(Blocks 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch v1 (obsolete) — Splinter Review
I think the only argument against this is that the pixman code might not be safe against timing attacks. But if that's the case then we're already vulnerable through more common uses of the code, e.g. through normal web page compositing.
Summary: Consider replacing the FilterNodeCompositeSoftware code with pixman compositing through DrawTargetCairo → Consider replacing the FilterNodeCompositeSoftware code with Skia compositing through DrawTargetSkia
Posted patch v2Splinter Review
Assignee: nobody → mstange
Attachment #8486409 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8498664 - Flags: review?(bas)
How about timing attacks with Skia?
Comment on attachment 8498664 [details] [diff] [review]
v2

Right, I still need to check that.
Attachment #8498664 - Flags: review?(bas)
Markus, any update on this? Could you unbitrot your patch?
Flags: needinfo?(mstange)
No update, but sure, I can update it.
As for the timing attacks, it's unlikely that Skia is vulnerable to them. Since we're using Skia composition for content drawing on some platforms now (and so is Chrome), we'd be vulnerable already.
Flags: needinfo?(mstange)
For the record: This patch will probably not improve the performance of the feComposite filter on desktop. Last I checked, the SSE2 code I wrote was roughly competitive with Skia.
I did not write a NEON version of the composite filter, but Skia has NEON versions for this, so this patch will definitely improve performance on Android.
You need to log in before you can comment on or make changes to this bug.