Closed
Bug 1064876
Opened 10 years ago
Closed 10 years ago
Enable web-platform-tests-reftests
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgraham, Assigned: jgraham)
Details
Attachments
(1 file, 1 obsolete file)
2.54 KB,
patch
|
jlund
:
review+
|
Details | Diff | Splinter Review |
Once they are stable enough. I think they probably already are, but I will check on cedar.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → james
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Attachment #8486418 -
Flags: review?(jgriffin)
Comment 2•10 years ago
|
||
Comment on attachment 8486418 [details] [diff] [review] Enable web-platform-tests reftests Review of attachment 8486418 [details] [diff] [review]: ----------------------------------------------------------------- Builders added: + Ubuntu VM 12.04 x64 ash opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 b2g-inbound opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 b2g-inbound pgo test web-platform-tests-reftests + Ubuntu VM 12.04 x64 cypress opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 elm opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 fig opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 fx-team opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 fx-team pgo test web-platform-tests-reftests + Ubuntu VM 12.04 x64 graphics opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 gum opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 holly opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 jamun opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 maple opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 mozilla-central opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 mozilla-central pgo test web-platform-tests-reftests + Ubuntu VM 12.04 x64 mozilla-inbound opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 mozilla-inbound pgo test web-platform-tests-reftests + Ubuntu VM 12.04 x64 oak opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 try opt test web-platform-tests-reftests + Ubuntu VM 12.04 x64 try pgo test web-platform-tests-reftests + Ubuntu VM 12.04 x64 ux opt test web-platform-tests-reftests We'll also enable linux32 builders as soon as bug 1064874 lands. Forward to jlund for final r?
Attachment #8486418 -
Flags: review?(jlund)
Attachment #8486418 -
Flags: review?(jgriffin)
Attachment #8486418 -
Flags: review+
Comment 3•10 years ago
|
||
Comment on attachment 8486418 [details] [diff] [review] Enable web-platform-tests reftests Review of attachment 8486418 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozilla-tests/config.py @@ -1870,3 @@ > # Enable wpt on opt linux64 for gecko >= 34 > for platform in PLATFORMS.keys(): > if platform not in ['linux', 'linux64']: hmm, this patch did not apply. It looks like it was diffed against something that was at least as old as aug 21[1] it looks like we rm 'linux' from wpt[2] is this patch still valid and what we want? [1] http://hg.mozilla.org/build/buildbot-configs/rev/7f1a761cc7db [2] http://mxr.mozilla.org/build/source/buildbot-configs/mozilla-tests/config.py#1791
Comment 4•10 years ago
|
||
> is this patch still valid and what we want? > ahh, and me sees Bug 1064874 next in my review queue that reflects this change. sorry, didn't realize this was a compound of other patch
Comment 5•10 years ago
|
||
Comment on attachment 8486418 [details] [diff] [review] Enable web-platform-tests reftests Review of attachment 8486418 [details] [diff] [review]: ----------------------------------------------------------------- similarly to bug 1064874, we need to from here: http://mxr.mozilla.org/build/source/buildbot-configs/mozilla-tests/config.py#1848 do something like this untested code: - BRANCHES['cedar']['platforms'][platform][slave_platform]['opt_unittest_suites'] += WEB_PLATFORM_REFTESTS[:] - if platform not in ('linux64',): - BRANCHES['cedar']['platforms'][platform][slave_platform]['opt_unittest_suites'] += WEB_PLATFORM_TESTS_CHUNKED[:] + if platform not in ('linux64', 'linux'): + BRANCHES['cedar']['platforms'][platform][slave_platform]['opt_unittest_suites'] += WEB_PLATFORM_TESTS_CHUNKED[:] + WEB_PLATFORM_REFTESTS[:]
Attachment #8486418 -
Flags: review?(jlund) → review-
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8494427 -
Flags: review?(jlund)
Assignee | ||
Updated•10 years ago
|
Attachment #8486418 -
Attachment is obsolete: true
Comment 7•10 years ago
|
||
Comment on attachment 8494427 [details] [diff] [review] Enable web-platform-tests reftests, Review of attachment 8494427 [details] [diff] [review]: ----------------------------------------------------------------- lgtm likewise, this will introduce PGO based reftests. this patch won't apply without bug 1064874 patch.
Attachment #8494427 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/build/buildbot-configs/rev/354c7bb33e24
Comment 9•10 years ago
|
||
Merged to production, and deployed.
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•