1064947 - Default specific prefs for 'Firefox Confidential'

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Karen Rudnitski [:kar]]

Set the following prefs for 'Firefox Confidential'
* Pref - Tracking = Do Not Track
* Pref - Cookies = Enabled, excluding third-party
* Pref - Crash reporter = disabled by default
* Pref - Telemetry = disabled by default

Comment 1

[Aaron Train [:aaronmt]]

(In reply to Karen Rudnitski [:kar] from comment #0)
> Set the following prefs for 'Firefox Confidential'
> * Pref - Crash reporter = disabled by default

Bad idea. Why the reasoning behind this?

Comment 2

[Karen Rudnitski [:kar]]

This is a good idea in light of this initiative because we can - depending on the crash - send information about a person's device and which URL they were on. For some people, they may not understand the intricacies of the information (and how we handle it) and would rather not send anything about their device back. Now just like FHR, we can display a snippet that includes good reasoning why a user may want to opt in to crash reporting. But because there isn't anything in it for them specifically, individuals should get a choice when they consciously make the decision to install this add-on.

Comment 3

[:Margaret Leibovic]

I don't think there's much value to disabling the crash reporter. We already prompt the user before sending a crash report, so they can decline when they are prompted.

I worry that there may be users who don't care about sending crash reports, but still want the rest of the features of the add-on, and I don't want us to lose out on crash data that we could have had.

Comment 4

[Karen Rudnitski [:kar]]

I don't know how to force my phone to crash. Is there a check-box already that allows the crash reporter to 'save my choice' if I decide not to send it? Or is the only way to disable the setting?

Comment 5

[:Margaret Leibovic]

(In reply to Karen Rudnitski [:kar] from comment #4)
> I don't know how to force my phone to crash.

ted has an add-on, but it's telling me it's not compatible with Fennec :(

http://ted.mielczarek.org/mozilla/crashme.html

ted, where's the source for this? Can I submit a PR to make it work with Fennec?

> Is there a check-box already
> that allows the crash reporter to 'save my choice' if I decide not to send
> it? Or is the only way to disable the setting?

I beleive we maintain the state of the checkboxes in the crash reporter (whether or not to submit a crash report, last url, email address). I think bnicholson worked on this, so asking him to confirm.

Another point: when the crash reporter comes up, it gives you the option to restart Fennec. If we totally disable the crash reporter, the browser will just crash and the user will be left with nothing. So I really don't think we should totally get rid of it.

Comment 6

[(not currently active) Ted Mielczarek]

This one should work:
http://people.mozilla.com/~tmielczarek/crashme/

Comment 7

[Karen Rudnitski [:kar]]

Ted - do you mean by 'work' in that it should force the crash? It's not working for me, if that's the case. But maybe that was just where it lived so Margaret could make it work, too - so just checking here. I'm eager to crash :)

Margaret - I hear what you're saying. Although when I have crashed, any time I selected 'restart' it would crash on me again. The only way I could get out of the cycle was to close it and start it back up. I don't think that's really a barrier, to be honest. If something closes, you'll just go to the app to start it back up. Could we throw up something to say that your browser will close and you need to open it back up?

Comment 8

[:Margaret Leibovic]

Okay, I decided to disable the crash reporter. We can always undo this change if we want.
https://github.com/leibovic/firefox-confidential/commit/d337b2541518854168be5801074e347eca47e3a4

Here's a version of the add-on you can test:
http://people.mozilla.org/~mleibovic/fxconfidential.xpi

I agree, I couldn't get the add-on to crash Fennec (there's a "Crash me!" menu item added to the main menu). Any ideas, ted?

Comment 9

[Karen Rudnitski [:kar]]

I've been thinking about this.

I found a screenshot of the metro crash reporter (https://bug903426.bugzilla.mozilla.org/attachment.cgi?id=8343538) which I thought would give me at least a decent idea of what the one in fennec looks like (they shouldn't be too far off in content or behaviour).

And the reason I was backing to include this pref is because of what we *may* take to include in the report. And then we're asking our users to trust in our privacy policy. Many would, but in light of all the privacy discussions in the media, many users wouldn't want this information to be sent on.

But here's what I'm thinking - and this may also go towards one of Brad's points he's been making offline to me. 

I'd like to get a landing page when the add-on is first installed (possible? if so, I can file a new bug). I'd like to detail out to the user relevant prefs we have turned off and and those we have kept on - including the crash reporter. We can link to our privacy policy as well as detail out what info we may send with every crash. Then the user can make the choice whether to keep it on or turn it off. 

This landing page would also tell a user the other mods made (addition of DDG for relevant locales, hopefully the https notification for search...)

Comment 10

[(not currently active) Ted Mielczarek]

(In reply to :Margaret Leibovic from comment #8)
> I agree, I couldn't get the add-on to crash Fennec (there's a "Crash me!"
> menu item added to the main menu). Any ideas, ted?

Bleh, something broke this at some point. It used to work. Now I get this in the logcat:
E/GeckoConsole(24602): [JavaScript Error: "TypeError: Crasher.crash is not a function" {file: "resource://gre/modules/addons/XPIProvider.jsm -> file:///data/data/org.mozilla.fennec/files/mozilla/bev18b55.default/extensions/[e-mail]/bootstrap.js" line: 155}]

Source is here if you want to poke at it:
https://code.google.com/p/crashme/source/checkout

The bootstrap.js is:
https://code.google.com/p/crashme/source/browse/trunk/bootstrap.js

Comment 11

[(not currently active) Ted Mielczarek]

If you can get a chrome JS shell open (browser console from a computer?) you can crash using ctypes like:
var zero = new ctypes.intptr_t(8);
var badptr = ctypes.cast(zero, ctypes.PointerType(ctypes.int32_t));
var crash = badptr.contents;