If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

undocumented Debugger methods

RESOLVED FIXED in mozilla35

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
mozilla35
x86_64
Linux
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The methods Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees
are in Debugger.cpp but are not documented in Debugger.md.
(Assignee)

Comment 1

3 years ago
Created attachment 8488753 [details] [diff] [review]
document Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees
Attachment #8488753 - Flags: review?(jimb)
(Assignee)

Updated

3 years ago
Assignee: nobody → ttromey
Status: NEW → ASSIGNED

Comment 2

3 years ago
Comment on attachment 8488753 [details] [diff] [review]
document Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees

Review of attachment 8488753 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great - thank you very much! Just one issue to address:

::: js/src/doc/Debugger/Debugger.md
@@ +260,5 @@
> +
> +    If this debugger is [tracking allocation sites][tracking-allocs] and cannot
> +    track allocation sites for some global, this method throws an `Error`.
> +    Otherwise this method returns `undefined`.
> +

I think we need a "WHOA NELLY NOT VERY CAPABILITY" warning for this function too, similar to the one that appears at the end of the description for onNewGlobalObject, above. Naturally, feel free to crib language from that as appropriate.
Attachment #8488753 - Flags: review?(jimb)
(Assignee)

Comment 3

3 years ago
Created attachment 8489525 [details] [diff] [review]
document Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees
Attachment #8489525 - Flags: review?(jimb)
(Assignee)

Updated

3 years ago
Attachment #8488753 - Attachment is obsolete: true

Comment 4

3 years ago
Comment on attachment 8489525 [details] [diff] [review]
document Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees

Review of attachment 8489525 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thank you very much!
Attachment #8489525 - Flags: review?(jimb) → review+

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc1ebbd01377
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fc1ebbd01377
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.