1064961 - undocumented Debugger methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Tromey :tromey]

The methods Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees
are in Debugger.cpp but are not documented in Debugger.md.

Comment 1

[Tom Tromey :tromey]

Attachment: document Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees

Comment 2

[Jim Blandy :jimb]

Comment on attachment 8488753 [details] [diff] [review]
document Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees

Review of attachment 8488753 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great - thank you very much! Just one issue to address:

::: js/src/doc/Debugger/Debugger.md
@@ +260,5 @@
> +
> +    If this debugger is [tracking allocation sites][tracking-allocs] and cannot
> +    track allocation sites for some global, this method throws an `Error`.
> +    Otherwise this method returns `undefined`.
> +

I think we need a "WHOA NELLY NOT VERY CAPABILITY" warning for this function too, similar to the one that appears at the end of the description for onNewGlobalObject, above. Naturally, feel free to crib language from that as appropriate.

Comment 3

[Tom Tromey :tromey]

Attachment: document Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees

Comment 4

[Jim Blandy :jimb]

Comment on attachment 8489525 [details] [diff] [review]
document Debugger.addAllGlobalsAsDebuggees and Debugger.removeAllDebuggees

Review of attachment 8489525 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thank you very much!

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc1ebbd01377

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fc1ebbd01377