1065070 - Remove GeckoAppShell.geckoLoaded

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Right now the only code in GeckoAppShell.geckoLoaded has to do with setting up GeckoEditable, but this can be done elsewhere without needing to post a Runnable.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Get rid of geckoLoaded call in GeckoAppShell (v1)

GeckoEditable initialization only depends on us having a LayerView, so it makes sense to move it to where we set our LayerView.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 8486656 [details] [diff] [review]
Get rid of geckoLoaded call in GeckoAppShell (v1)

Review of attachment 8486656 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: mobile/android/base/GeckoAppShell.java
@@ +299,5 @@
>      private static LayerView sLayerView;
>  
>      public static void setLayerView(LayerView lv) {
> +        if (sLayerView == lv) {
> +            return;

Does this ever happen? Would this indicate a bug? If so, then consider logging a warning or throw an exception.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Chris Peterson (:cpeterson) from comment #2)
> Comment on attachment 8486656 [details] [diff] [review]
> Get rid of geckoLoaded call in GeckoAppShell (v1)
> 
> Review of attachment 8486656 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM!
> 
> ::: mobile/android/base/GeckoAppShell.java
> @@ +299,5 @@
> >      private static LayerView sLayerView;
> >  
> >      public static void setLayerView(LayerView lv) {
> > +        if (sLayerView == lv) {
> > +            return;
> 
> Does this ever happen? Would this indicate a bug? If so, then consider
> logging a warning or throw an exception.

I think this might happen when "Don't keep activities" is turned on?

https://hg.mozilla.org/integration/mozilla-inbound/rev/198f2849d795

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/198f2849d795