1065167 - [email] The contents of the outbox won't show until any active sending process completes due to held mutex by sending process

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Seth Miko [:SMiko]]

Attachment: outbox2.txt

Description: Emails are not displayed in the outbox while in the process of being sent. 
According to user story: Bug 949498, emails should be placed in the outbox until the transmission completes. 

Repro Steps:
1: Update a Flame to 20140908000204
2: Open Email and create a new email
3: Attach a video around 5 seconds in length and hit Send
4: While the email is sending, switch to the outbox

Actual:
The email does not appear, even when refreshing

Expected:
The email is displayed in the outbox until the transmission completes. 

Flame 2.1(319mb)

Environmental Variables:
Device: Flame 2.1 (319mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes:
Emails DO appear in the outbox until sent when composing the email while in the outbox folder

Repro frequency: 100%

See attached: logcat

Video clip:http://youtu.be/Mobt2zIaV8A

Comment 1

[Seth Miko [:SMiko]]

This issue DOES occur on Flame 2.2(319mb), Open C 2.2, Flame 2.1(512mb), Open C 2.1, 

Actual result:
Email is not shown in outbox

Flame 2.2 (319mb)

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Open C 2.2

Environmental Variables:
Device: Open_C Master 
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 (512mb)

Environmental Variables:
Device: Flame 2.1(512mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.1

Environmental Variables:
Device: Open_C 2.1 
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


This issue does NOT occur on Flame 2.0(319mb), or Open C 2.0 as the outbox feature does not exist

Flame 2.0 (319mb)

Environmental Variables:
Device: Flame 2.0 (319mb)
Build ID: 20140908000202
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open_C 2.0

Environmental Variables:
Device: Open_C 2.0 
Build ID: 20140908000202
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Edward, can you look at this and weigh in on whether or not this should block 2.1?

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

It's a mutex issue.  We could probably mitigate the outbox and local drafts case separately since they don't actually have a sync process and therefore they don't actually need to hold a mutex when syncing.  (All of their mutating operations run via job-ops.)

Specifically, we could probably make FolderStorage.sliceOpenMostRecent and FolderStorage.refreshSlice explicitly bypass runMutexed when they are isLocalOnly() (providing a no-op completion callback) as our stop-gap.

:mcav, does that sound sane to you?

Comment 4

[Marcus Cavanaugh [:mcav]]

Yeah, that's doable.

Comment 5

[Edward Chen[:edchen]]

[Blocking Requested - why for this release]:

Comment 6

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/338

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8487370 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/338

r=asuth, and the patch speaks for itself fantastically with comments.  In the event I do not say it enough, I am so happy that you are hacking on the email back-end.  I feel like I should get one of those Staples "easy" buttons and hack it to be you saying "It's handled."  Now I just need to do the Sneakers (movie) thing where I get some random person to trick you into saying "It's handled" without you being the wiser...

Comment 8

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/0cb9094aab4672c4c35963b76e8f1f323689ec9c

Comment 9

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8487370 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/338

[Approval Request Comment]

Requesting uplift to 2.1; low-risk fix that allows the outbox to be displayed properly while other operations are going on in the Email app.

[Bug caused by] (feature/regressing bug #): outbox feature, in v2.1
[User impact] if declined: see bug title
[Testing completed]: yes, automated/manual
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 10

[Dylan Oliver [:doliver]]

triage: not blocking, does not meet the bar of "major issue" in new feature. will wait for approval decision

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/71daa38a9c2983ffa1a2151429e44383bf9e3aee

Comment 12

[Edward Chen[:edchen]]

[Environment]
Gaia-Rev        b3f9b97d16a1ab55f80239d63c1a85c3da3d39ad
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/2c6e3261c47b
Build ID        20140921160204
Version         34.0a2
Device Name     flame
FW-Release      4.3
FW-Incremental  110
FW-Date         Fri Jun 27 15:57:58 CST 2014
Bootloader      L1TC00011230

[Result]
PASS

Comment 13

[Alissa（leave from Mozilla）]

Attachment: verify.3gp

This issue has been successfully verified on Flame 2.1, 2.2
See attachment:verify.3gp
Reproducing rate: 0/5

Flame 2.1 new build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0

Flame 2.2 version:
Gaia-Rev        725685831f5336cf007e36d9a812aad689604695
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID        20141202040207
Version         37.0a1