1065218 - Switch MediaSourceReader timestamp handling from double/seconds to int64_t/microseconds

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

As mentioned in bug 1062670 comment 2.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Convert MediaSourceReader timestamp handling to int64_t/microseconds.

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8486916 [details] [diff] [review]
Convert MediaSourceReader timestamp handling to int64_t/microseconds.

This also removes SourceBufferDecoder::ContainsTime, since it's only ever used in an assertion (and that assertion will be reported by seek returning an NS_ERROR, anyway).

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: Convert MediaSourceReader timestamp handling to int64_t/microseconds.

Rebased.

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 8486975 [details] [diff] [review]
Convert MediaSourceReader timestamp handling to int64_t/microseconds.

(In reply to Matthew Gregan [:kinetik] from comment #2)
> This also removes SourceBufferDecoder::ContainsTime, since it's only ever
> used in an assertion (and that assertion will be reported by seek returning
> an NS_ERROR, anyway).

I'm not clear that ContainsTime() failure always implies Seek() failure, but that is quite a bit of code for the sake of an assertion that sometimes fails anyway (bug 1064113), so that shouldn't get in the way of progress here.

Comment 5

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=9c8b65ba2c17

Comment 6

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=fcd8ab9af2ed

Comment 7

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=574681747a04

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac2775cadc7c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ac2775cadc7c