1065259 - ////# sourceURL is not recognized as source URL

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sebastian Zartner [:sebo]]

Source URLs are just recognized when they follow the exact syntax '//# sourceURL' or '//@ sourceURL'.

Though e.g. in case of the dojo Framework source URLs are preceeded by two additional slashes[1], i.e. '////@ sourceURL', due to a compatibility issue in IE9.
So they are not recognized and saved within the 'displayURL' property.

Sebastian

[1] https://bugs.dojotoolkit.org/ticket/12672#comment:103

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

The reason all devtools moved to "//#" from "//@" was that same IE issue. In the meantime, they could just use "//#" and avoid the problems they originally prepended the extra "//" for.

Comment 2

[Sebastian Zartner [:sebo]]

This was obviously already discussed with the dojo team lately[1] and changed in the dojo code[2] a few days ago. So there is no worry for future versions of dojo. Though it takes time until that is adopted by web developers, so I believe it's still required to support the legacy syntax (besides that it's that easy to do that[3]).

Sebastian

[1] https://code.google.com/p/chromium/issues/detail?id=401339#c11
[2] https://github.com/dojo/dojo/commit/edd76ffa0b4d591a864754747721e11898712c2d
[3] https://github.com/firebug/firebug/compare/master...issue7201

Comment 3

[Logan Smyth [:loganfsmyth]]

This seems to have been addressed via //# instead of //@ long enough ago that I'm just gonna close.

Comment 4

[Sebastian Zartner [:sebo]]

Point was that dojo used to use four slashes instead of two back in that days and that those comments weren't recognized as source URLs. Though it was also around that time when the dojo developers switched their framework to two slashes and I guess that now enough time has passed that it's ok you closed that bug report. (But maybe parsing source URLs with four slashes also works now, didn't test it.)

Sebastian

Comment 5

[Logan Smyth [:loganfsmyth]]

I'm assuming enough time has passed that it's probably not worth addressing, especially since as far as I can see the four-slash version isn't really documented anywhere as usable or expected to work.