1065290 - [Settings] refactor Homescreens panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Refactor Homescreen panel with AMD pattern referring to
https://github.com/mozilla-b2g/gaia/tree/master/apps/settings

to make it modularize and more easier to maintain


Expected Results:

pass all settings test and act the same as original implementation

Comment 1

[[e-mail]]

Attachment: pull request redirect to github

WIP

Comment 2

[[e-mail]]

Comment on attachment 8489783 [details] [review]
pull request redirect to github

separate to homescreens/homescreens_details panels, test added

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8489783 [details] [review]
pull request redirect to github

Thanks Fred, 

just left some comments on Github and please check it ! Thanks :)

Comment 4

[[e-mail]]

Comment on attachment 8489783 [details] [review]
pull request redirect to github

Thanks EJ! 

comment addressed, please kindly review it again

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8489783 [details] [review]
pull request redirect to github

Fred, just noticed a critical problem in the patch and please check Github. 

And based on our offline experiments, please try to create another new homescreen copied from `verticalhome` and use `navigator.mozSettings.createLock().get('xxx')` when testing (e.g. console panel in nightly) to make sure homescreen would be changed.

Thanks.

Comment 6

[[e-mail]]

Comment on attachment 8489783 [details] [review]
pull request redirect to github

Thanks for finding the issue!

New version fixed by onBeforeShow and can switch homescreen well. Please kindly review it again.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8489783 [details] [review]
pull request redirect to github

Fred, I think this is last comment which needs to be addressed.

Thanks !!

Comment 8

[[e-mail]]

Comment on attachment 8489783 [details] [review]
pull request redirect to github

Issue addressed, Please kindly review it again!

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8489783 [details] [review]
pull request redirect to github

Thanks Fred !! :)

r+

Comment 10

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/771919fa0b864e71413ee3161f432ff673eb9924

thanks!