Implement ServiceWorkerGlobalScope update()

RESOLVED FIXED in mozilla37

Status

()

defect
RESOLVED FIXED
5 years ago
a month ago

People

(Reporter: baku, Assigned: baku)

Tracking

(Blocks 1 bug, {dev-doc-needed})

Trunk
mozilla37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
(Assignee)

Comment 1

5 years ago
Posted patch update.patch (obsolete) — Splinter Review
I want to add a mochitest for this.
(Assignee)

Updated

5 years ago
Attachment #8487339 - Flags: feedback?(nsm.nikhil)
Comment on attachment 8487339 [details] [diff] [review]
update.patch

Review of attachment 8487339 [details] [diff] [review]:
-----------------------------------------------------------------

[[Update]] has changed to return the promise of [[Install]]. This could affect some of the parameters we need to pass to relevant methods and things. I'll take a look at this on Monday after going over some of those changes.

::: dom/workers/WorkerScope.cpp
@@ +575,5 @@
> +    : mWorkerPrivate(aWorkerPrivate)
> +    , mScope(aScope)
> +  { }
> +
> +  NS_IMETHODIMP Run() MOZ_OVERRIDE

Nit: Run on the next line.
(Assignee)

Comment 3

5 years ago
nsm news about this feedback/review?
Flags: needinfo?(nsm.nikhil)
Comment on attachment 8487339 [details] [diff] [review]
update.patch

Review of attachment 8487339 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/base/nsIServiceWorkerManager.idl
@@ +85,5 @@
>  
> +  /*
> +   * This implements the update algorithm.
> +   */
> +  void update(in DOMString aScope);

bump the UUID?

::: dom/workers/WorkerScope.cpp
@@ +566,5 @@
> +namespace {
> +
> +class UpdateRunnable MOZ_FINAL : public nsRunnable
> +{
> +  WorkerPrivate* mWorkerPrivate;

never used

@@ +575,5 @@
> +    : mWorkerPrivate(aWorkerPrivate)
> +    , mScope(aScope)
> +  { }
> +
> +  NS_IMETHODIMP Run() MOZ_OVERRIDE

Nit: Run on the next line.
Attachment #8487339 - Flags: feedback?(nsm.nikhil) → feedback+
(Assignee)

Comment 5

5 years ago
Posted patch update.patchSplinter Review
I don't see any change in the spec about 'update'.
Attachment #8487339 - Attachment is obsolete: true
Attachment #8498857 - Flags: review?(nsm.nikhil)
(Assignee)

Comment 6

5 years ago
I'll land this patch to maple.
https://hg.mozilla.org/mozilla-central/rev/d1c7890bcdc2
Assignee: nobody → amarchesini
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.