1065366 - Implement ServiceWorkerGlobalScope update()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: update.patch

I want to add a mochitest for this.

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8487339 [details] [diff] [review]
update.patch

Review of attachment 8487339 [details] [diff] [review]:
-----------------------------------------------------------------

[[Update]] has changed to return the promise of [[Install]]. This could affect some of the parameters we need to pass to relevant methods and things. I'll take a look at this on Monday after going over some of those changes.

::: dom/workers/WorkerScope.cpp
@@ +575,5 @@
> +    : mWorkerPrivate(aWorkerPrivate)
> +    , mScope(aScope)
> +  { }
> +
> +  NS_IMETHODIMP Run() MOZ_OVERRIDE

Nit: Run on the next line.

Comment 3

[Andrea Marchesini [:baku]]

nsm news about this feedback/review?

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8487339 [details] [diff] [review]
update.patch

Review of attachment 8487339 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/base/nsIServiceWorkerManager.idl
@@ +85,5 @@
>  
> +  /*
> +   * This implements the update algorithm.
> +   */
> +  void update(in DOMString aScope);

bump the UUID?

::: dom/workers/WorkerScope.cpp
@@ +566,5 @@
> +namespace {
> +
> +class UpdateRunnable MOZ_FINAL : public nsRunnable
> +{
> +  WorkerPrivate* mWorkerPrivate;

never used

@@ +575,5 @@
> +    : mWorkerPrivate(aWorkerPrivate)
> +    , mScope(aScope)
> +  { }
> +
> +  NS_IMETHODIMP Run() MOZ_OVERRIDE

Nit: Run on the next line.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: update.patch

I don't see any change in the spec about 'update'.

Comment 6

[Andrea Marchesini [:baku]]

I'll land this patch to maple.

Comment 7

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=62579957addd
and
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1c7890bcdc2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1c7890bcdc2